Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize graph calculus #557

Merged
merged 12 commits into from
Oct 9, 2023
Merged

Optimize graph calculus #557

merged 12 commits into from
Oct 9, 2023

Conversation

Sichao25
Copy link
Collaborator

@Sichao25 Sichao25 commented Jul 7, 2023

  • Combine graphize_velocity_coopt and _graphize_velocity_coopt into one function.
  • Add the weighted mode for divergence.
  • Add a few tests for graph calculus

@Sichao25 Sichao25 marked this pull request as ready for review July 11, 2023 22:28
@Sichao25 Sichao25 requested a review from Xiaojieqiu July 31, 2023 23:13
@codecov-commenter
Copy link

codecov-commenter commented Sep 29, 2023

Codecov Report

Merging #557 (88b8577) into master (153f5b7) will increase coverage by 0.40%.
The diff coverage is 49.36%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@            Coverage Diff             @@
##           master     #557      +/-   ##
==========================================
+ Coverage   22.32%   22.73%   +0.40%     
==========================================
  Files         158      160       +2     
  Lines       26356    26406      +50     
==========================================
+ Hits         5885     6003     +118     
+ Misses      20471    20403      -68     
Files Coverage Δ
tests/test_estimation.py 100.00% <100.00%> (ø)
tests/test_tools.py 100.00% <100.00%> (ø)
dynamo/tools/graph_operators.py 24.63% <0.00%> (ø)
dynamo/tools/graph_calculus.py 19.29% <13.18%> (+9.50%) ⬆️

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Xiaojieqiu Xiaojieqiu merged commit af1a6d7 into master Oct 9, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants