Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set telemetry content field name with serde(rename) for serializer compatibility #101

Merged
merged 1 commit into from
Dec 5, 2024
Merged

Set telemetry content field name with serde(rename) for serializer compatibility #101

merged 1 commit into from
Dec 5, 2024

Conversation

sksat
Copy link
Member

@sksat sksat commented Dec 5, 2024 •
edited
Loading

@sksat
set telemetry content field name as entries with serde(rename) instea…
1c04c5a 
…d of serde(rename) for serializer compatibility
@sksat sksat self-assigned this Dec 5, 2024
@sksat
Copy link
Member Author

sksat commented Dec 5, 2024

ただ、 #24 を見る限り、元の意図としては（少なくとも blob は）content: になってほしい、のか（まあ entries ではないしな）

@sksat
Copy link
Member Author

sksat commented Dec 5, 2024

あと、display info も増えてる（#41）ので、これだけでは問題は解決しない

@sksat sksat mentioned this pull request Dec 5, 2024
Closed
@sksat
Copy link
Member Author

sksat commented Dec 5, 2024

"entries": "blob" になるのは違うとは思うが、現時点で blob tlm を含んだ tlmcmddb.json はごくわずかしか発生していないため、一旦 rename で v2.5 以前との互換性を回復する。

@sksat sksat merged commit 99f4988 into main Dec 5, 2024
1 check failed
@sksat sksat deleted the rename-tlm-entries-field-for-serialize-compatibility branch December 5, 2024 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@sksat sksat

Labels
priority::high
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@sksat