feat(attest): add Bun support #1130
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ssalbdivad
reviewed
Sep 15, 2024
tsconfig.json
Outdated
| @@ -3,7 +3,8 @@ | |||
| "compilerOptions": { | |||
| "allowImportingTsExtensions": true, | |||
| "customConditions": ["ark-ts"], | |||
| "types": ["mocha", "node"] | |||
| "types": ["mocha", "node"], | |||
| "allowJs": true | |||
There was a problem hiding this comment.
Can't add allowJS, it screws the repo's typecheck time.
ssalbdivad
reviewed
Sep 15, 2024
| @@ -41,7 +42,7 @@ export const forTypeScriptVersions = ( | |||
| try { | |||
| if (existsSync(tsPrimaryPath)) unlinkSync(tsPrimaryPath) | |||
|
|
|||
| symlinkSync(targetPath, tsPrimaryPath) | |||
| symlinkSync(targetPath, tsPrimaryPath, "junction") | |||
There was a problem hiding this comment.
This is also from the other PR correct? It's possible though that this does break on Windows as the cross-os CI doesn't run across multiple TS versions.
There was a problem hiding this comment.
The version that doesn't touch default TS was not on main yet so I did need this
There was a problem hiding this comment.
Still, I'd rather pnpm testTsVersions work on Windows as well, so you can leave this in. Just not sure about the build stuff from the other PR.
There was a problem hiding this comment.
I'll may drop this commit from this PR later, I did need it to test if it does work
ssalbdivad
reviewed
Sep 15, 2024
| "prettier": "3.3.3", | ||
| "@prettier/sync": "0.5.2" | ||
| "synckit": "^0.9.1" |
ssalbdivad
changed the title
Dimava
force-pushed
the
dimava/attest-bun
branch
from
a10eb2e
to
50c7497
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.