Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add armada email field to profile #888

Merged
merged 3 commits into from
Aug 9, 2023
Merged

feat: Add armada email field to profile #888

merged 3 commits into from
Aug 9, 2023

Conversation

didrikmunther
Copy link
Contributor

@didrikmunther didrikmunther commented Aug 8, 2023 •
edited
Loading

Describe your changes

Fixes: #805

Checklist before requesting review

  • Feature/fix PRs should add one atomic (as small as possible) feature or fix.
  • The code compiles and all the tests pass.

@didrikmunther didrikmunther marked this pull request as ready for review August 9, 2023 07:57
hampfh
hampfh approved these changes Aug 9, 2023
View reviewed changes
Copy link
Member

@hampfh hampfh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@didrikmunther didrikmunther merged commit adfd644 into master Aug 9, 2023
2 checks passed
@didrikmunther didrikmunther deleted the didrik/feat/add-armada-email branch August 9, 2023 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hampfh hampfh hampfh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add email field to API
2 participants
@didrikmunther @hampfh