Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix permissions for creating new recruitment period #919

Merged
merged 2 commits into from
Aug 15, 2023
Merged

fix: Fix permissions for creating new recruitment period #919

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ef28a3f
Fix permissions for creating new recruitment period
didrikmunther Aug 15, 2023
b870788
Format files
didrikmunther Aug 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions recruitment/views.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -807,8 +807,12 @@ def recruitment_period_delete(request, year, pk):
def recruitment_period_edit(request, year, pk=None):
recruitment_period = RecruitmentPeriod.objects.filter(pk=pk).first()

if not user_can_access_recruitment_period(request.user, recruitment_period):
return HttpResponseForbidden()
if pk != None:
if not user_can_access_recruitment_period(request.user, recruitment_period):
return HttpResponseForbidden()
else:
if not request.user.has_perm("recruitment.add_recruitmentperiod"):
return HttpResponseForbidden()

fair = get_object_or_404(Fair, year=year)
form = RecruitmentPeriodForm(request.POST or None, instance=recruitment_period)
Expand Down
Loading