Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gray-streams:stream-file-length support #636

Merged
merged 1 commit into from
Nov 19, 2023

Conversation

yitzchak
Copy link
Contributor

An extension to Gray streams which allows implementing CL:FILE-LENGTH. Supported by CMUCL, Mezzano, Lispworks, and SBCL. Recently added to Clasp and ECL.

@easye
Copy link
Collaborator

easye commented Nov 19, 2023

Looks good as an implementation as far as I can see so far.

@yitzchak Curious whether this extension to GRAY-STREAMS is being documented/standardized anywhere? I'd perhaps like to add a bit of text to the ABCL user manual to note the addition, so looking for something to reference. And I'd like to understand what else ABCL may be missing that is common in other implementations.

Thanks for the patch!

@yitzchak
Copy link
Contributor Author

yitzchak commented Nov 19, 2023

I may submit it to trivial-gray-streams, but I am bit on the fence about that since I have some concerns with how trivial-gray-streams has been implemented. I have started nontrivial-gray-streams which is what I think trivial-gray-streams should have been. It includes some initial documentation on the various extensions and the start of a test suite. It also adds features indicating each implementation's support for extensions and capabilities. Still early days, though.

@easye
Copy link
Collaborator

easye commented Nov 19, 2023

I may submit it to trivial-gray-streams […]

Actually, ABCL doesn't have any documentation on its GRAY-STREAMS implementation in our manual at the moment, so adding something quickly won't necessarily be easy.

I'll merge this pull request as-is, follow your progress on https://github.com/yitzchak/nontrivial-gray-streams, and deal with some ABCL-side documentation in the future.

@yitzchak
Copy link
Contributor Author

Sounds good. Thanks!

@easye easye merged commit 691d0f0 into armedbear:master Nov 19, 2023
8 checks passed
@yitzchak yitzchak deleted the stream-file-length branch November 19, 2023 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants