Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use STREAMP to determine Gray stream API availability #648

Merged
merged 1 commit into from
Dec 13, 2023

Conversation

yitzchak
Copy link
Contributor

@yitzchak yitzchak commented Dec 12, 2023

Using (typep obj 'stream) effectively makes the generic function STREAMP not very useful since all streams need to subclass STREAM, which always returns T for STREAMP. This is an optional part of the Gray stream protocol. Some implementations enforce the requirement that streams must subclass STREAM, i.e. CMUCL, SBCL and CLISP. On the other hand Clasp, ECL, MKCL, Mezzano and CCL all implement the generic STREAMP and don't require that Gray streams subclass STREAM.

@easye
Copy link
Collaborator

easye commented Dec 13, 2023

Your reasoning about streamp makes sense to me: I certainly think it is better than the current situation. Thanks!

@easye easye merged commit f4ebe57 into armedbear:master Dec 13, 2023
8 checks passed
@yitzchak yitzchak deleted the gray-streamp branch December 13, 2023 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants