Allow automatic port selection by tomcat #116
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description of what this resolves:
As discussed in here: #115 here the pull request to allow automatic port selection by the arquillian tomcat plugin.
I added comments to all done changes.
Changes proposed in this pull request:
Fixes: #
changed final HTTPContext httpContext = new HTTPContext(configuration.getBindAddress(), configuration.getBindHttpPort()); to new HTTPContext(tomcat.getHost().getName(), tomcat.getConnector().getLocalPort()); in Tomcat8EmbeddedContainer.java so HTTPContext uses port choosen by Tomcat, and no longer set by user in configuration. This allows setting of 0 and to let tomcat choose an available port by its own.
changed ((StandardHost) host).setUnpackWARs(configuration.isUnpackArchive()); back to embeddedHostConfig.setUnpackWARs(configuration.isUnpackArchive()); because in out arquillian setup, ((StandardHost) host).setUnpackWARs(configuration.isUnpackArchive()); will not work propably