Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests should (optionally) fail if container env not available #42

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

jasondlee
Copy link
Collaborator

@jasondlee jasondlee commented Nov 15, 2024

Add sys prop check to determine whether to fail hard

@jasondlee jasondlee requested a review from jamezp November 15, 2024 17:24
@jamezp
Copy link
Collaborator

jamezp commented Nov 15, 2024

ha, I just left a comment on the issue, but maybe we could have an option to have a system property like org.arquillian.testcontainers.required.exception=java.lang.AssertionError and allow the type to be overridden.

@jasondlee
Copy link
Collaborator Author

@rhusar @jamezp I have updated the PR with the code to allow a sysprop override of the exception. Please review and provide feedback...

@jasondlee jasondlee marked this pull request as ready for review November 18, 2024 17:48
Copy link
Collaborator

@rhusar rhusar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer the deleting approach. But OK as a temporary fix.

@rhusar
Copy link
Collaborator

rhusar commented Nov 19, 2024

@jamezp gets the final say :-)

@jasondlee jasondlee merged commit 33fb079 into arquillian:main Nov 19, 2024
7 checks passed
@jasondlee jasondlee deleted the ARQTC-41 branch November 19, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants