Update Ike's reaction in the PR if the state changes

[gastaldi]

About the plug-in that checks for tests in a PR, it would be nice if Ike's reaction (in the PR comment) were updated when the PR is updated.

Even though that the PR status changes accordingly, updating the comment with Ike's feedback would be a nice visual indicator for PR reviewers ;)

[maxandersen]

isn't this more apropriately done by a new comment + update via status api ?

[gastaldi]

@maxandersen I'd prefer to update the existing comment instead of adding new comments as this can confuse someone when reviewing the PR (specially if it has a lot of comments)

[maxandersen]

then I would say better to use status api updates rather than comments. ie. like a failed build or linting check.

Could also make the icon slightly smaller so it does not take up that amount of visual space :)

[gastaldi]

It would be nice to display it in the newest Checks tab: https://help.github.com/articles/about-status-checks/#checks

[MatousJobanek]

Hi guys,

I finally got to this issue - sorry for the delay.

I'd prefer to update the existing comment instead of adding new comments as this can confuse someone when reviewing the PR (especially if it has a lot of comments)

as for the update of the message hint - we have thee options here:

1. remove the comment and add a new one
2. update the current comment
3. remove the comment and don't add any new one
   I can imagine that adding a new comment can be quite annoying - especially when there is some ongoing discussion, so I would vote for either the second or the third option.

then I would say better to use status api updates rather than comments.

we do use it and we add also details link there to a page that explains what is going on, but nobody has noticed it obviously :-). There are two reasons why we add the comment there.

1. when there is a PR without a test, we want to do the maximum to force the committer to add a test to the PR.
2. we can customize the message taking information from the project/configuration file and also by mentioning the committer there

Could also make the icon slightly smaller so it does not take up that amount of visual space :)

It is still possible to customize the message in every project separately by using a config file, so you can define your own message, that will be shorter and without any images.
But if you agree on the image being too big, then I can definitely make it smaller ;-)

It would be nice to display it in the newest Checks tab

First of all, we would have to make the Ike plugins a GH app, then we can use the checks tab. There is an issue for it: #59

[MatousJobanek]

So, my proposal is:

• If there is no test, then the comment will contain a smaller image and will look like:

• if a test is added, then the message wiil be modified to:

• if the PR is updated so all changed files are skipped by exclusion, then the message will be modified to:

And yeah, the comment will be added only when the PR is submitted/updated by a commit that doesn't contain any test.