feat(#145): rework hint to status message that can be updated when status is changed #209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatousJobanek
force-pushed
the
issue-148-update-hint
branch
2 times, most recently
from
d36ab83 to
0e27c6a
Compare
MatousJobanek
changed the title
…ed when status is changed
MatousJobanek
force-pushed
the
issue-148-update-hint
branch
from
2b6292a to
7f9118c
Compare
bartoszmajsak
requested changes
Jun 22, 2018
docs/fragments/pr-sanitizer.adoc
Outdated
| @@ -35,5 +35,7 @@ include::../../pkg/plugin/pr-sanitizer/test_fixtures/github_calls/pr-sanitizer.y | |||
|
|
|||
| === Status details | |||
|
|
|||
| Here, you can find status details description applicable for each state of the `pr-sanitizer` plugin. | |||
There was a problem hiding this comment.
I would replace Here, with In this section
docs/fragments/work-in-progress.adoc
Outdated
| @@ -40,5 +40,7 @@ include::../../pkg/plugin/work-in-progress/test_fixtures/github_calls/work-in-pr | |||
|
|
|||
| === Status details | |||
|
|
|||
| Here, you can find status details description applicable for each state of the `work-in-progress` plugin. | |||
There was a problem hiding this comment.
I would replace Here,withIn this section`
| if strings.TrimSpace(content) == strings.TrimSpace(*statusMsg) { | ||
| return nil | ||
| } | ||
| return s.commentService.EditComment(*com.ID, statusMsg) |
There was a problem hiding this comment.
I'm not sure we should edit comments. I look at PR comments (and events) as a timeline so I would rather append new comments with the relevant message. Maybe we can extend the message to point to commit? "It seems that prior to commit 6fas341213ad3a there are no tests in this PR" or sth like - to get the idea, as the wording is not ideal. WDYT?
| Ω(err).ShouldNot(HaveOccurred()) | ||
| }) | ||
|
|
||
| It("should modify existing comment when a new message is provided", func() { |
There was a problem hiding this comment.
I am not sure if it is not confusing. We rarely modify our own comments to keep the context of the discussion right, so why would bot do that?
bartoszmajsak
previously approved these changes
Jun 25, 2018
bartoszmajsak
approved these changes
Jun 25, 2018
dipak-pawar
approved these changes
Jun 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test-keeperwhere different messages are set for the cases when either the PR is updated by commit containing a test or is updated so it contains only skipped files - for more information see this comment Update Ike's reaction in the PR if the state changes #145 (comment).mdfiles in.ike-prow/directorytest-keeper_without_tests_message.mdfor the case when no tests is addedtest-keeper_with_tests_message.mdfor the case when PR is updated by a commit containing a testtest-keeper_only_skipped_message.mdfor the case when PR is updated so it contains only those files that are skippedFixes: #145
TODO: