Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix format when setting all day #69

Merged
merged 1 commit into from
Apr 25, 2023
Merged

fix format when setting all day #69

merged 1 commit into from
Apr 25, 2023

Conversation

jackhopner
Copy link
Contributor

Using the implementation from #61 however removing the call to UTC(), time.Time already holds timezone information so users can set the location using In(tz) on the time.Time object itself.

arran4
arran4 approved these changes Apr 25, 2023
View reviewed changes
Copy link
Owner

@arran4 arran4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arran4 arran4 merged commit f69e132 into arran4:master Apr 25, 2023
@arran4
Copy link
Owner

arran4 commented Apr 25, 2023

Did this resolve any existing issue?

@jackhopner
Copy link
Contributor Author

@arran4 should resolve #55

@dnwe dnwe mentioned this pull request Apr 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arran4 arran4 arran4 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jackhopner @arran4