Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error handling #73

Open
wants to merge 68 commits into
base: master
Choose a base branch
from
Open

Error handling #73

wants to merge 68 commits into from

Commits on Apr 3, 2023

  1. Add Todo and Journal Property Methods

    - Add methods for VTodo and VJournal
    - Changed the shared properties to be attached to the ComponentBase
      so those methods don't need to be repeated across all attributes
      that share them
    - If a property is shared across some, but not all components, then
      it's a private method on the ComponentBase and public method on
      the Components (eg LOCATION for Event and Todo but not Journal)
    - Shifted position of some Event methods in the file to live after
      the VEvent struct
    spslater committed Apr 3, 2023
    Configuration menu
    Copy the full SHA
    08adbda View commit details
    Browse the repository at this point in the history
  2. Add Alarm, Timezone, and FreeBusy Property Methods

    - Add methods for Alarm, Timezone, and FreeBusy
    - Only methods for creating and adding right now, will add methods
      for the properties unique to them later
    spslater committed Apr 3, 2023
    Configuration menu
    Copy the full SHA
    14095cc View commit details
    Browse the repository at this point in the history

Commits on Apr 6, 2023

  1. Fix Typos in a couple places

    - Recursive call for Alarms
    - SetGeo was not a public method
    - Missing comma in struct creation
    spslater committed Apr 6, 2023
    Configuration menu
    Copy the full SHA
    67727dd View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    b51e64d View commit details
    Browse the repository at this point in the history

Commits on Apr 27, 2023

  1. Configuration menu
    Copy the full SHA
    6d4f14f View commit details
    Browse the repository at this point in the history

Commits on Apr 28, 2023

  1. Configuration menu
    Copy the full SHA
    a5a215d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    4b2d6a1 View commit details
    Browse the repository at this point in the history

Commits on Jul 12, 2023

  1. Configuration menu
    Copy the full SHA
    23c4714 View commit details
    Browse the repository at this point in the history
  2. fixed some namings

    ManoloTonto1 committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    b69874f View commit details
    Browse the repository at this point in the history

Commits on Sep 6, 2023

  1. Bump gopkg.in/yaml.v3 from 3.0.0-20210107192922-496545a6307b to 3.0.0

    Bumps gopkg.in/yaml.v3 from 3.0.0-20210107192922-496545a6307b to 3.0.0.
    
    ---
    updated-dependencies:
    - dependency-name: gopkg.in/yaml.v3
      dependency-type: indirect
    ...
    
    Signed-off-by: dependabot[bot] <[email protected]>
    dependabot[bot] authored Sep 6, 2023
    Configuration menu
    Copy the full SHA
    7d97e96 View commit details
    Browse the repository at this point in the history
  2. Merge pull request arran4#76 from arran4/dependabot/go_modules/gopkg.…

    …in/yaml.v3-3.0.0
    
    Bump gopkg.in/yaml.v3 from 3.0.0-20210107192922-496545a6307b to 3.0.0
    arran4 authored Sep 6, 2023
    Configuration menu
    Copy the full SHA
    ce8cff1 View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2023

  1. Configuration menu
    Copy the full SHA
    0abebc2 View commit details
    Browse the repository at this point in the history

Commits on Nov 11, 2023

  1. Merge pull request arran4#80 from coachclientconnect/add-get-timestamp

    Add VEvent.GetDtStampTime
    arran4 authored Nov 11, 2023
    Configuration menu
    Copy the full SHA
    acf49e9 View commit details
    Browse the repository at this point in the history

Commits on Nov 23, 2023

  1. Configuration menu
    Copy the full SHA
    a0f11e3 View commit details
    Browse the repository at this point in the history
  2. undo formatting change

    zachmann committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    70f69c8 View commit details
    Browse the repository at this point in the history

Commits on Nov 24, 2023

  1. Configuration menu
    Copy the full SHA
    1dfe73f View commit details
    Browse the repository at this point in the history
  2. Merge pull request arran4#81 from zachmann/master

    add possibility to remove VEvent from calendar by id
    arran4 authored Nov 24, 2023
    Configuration menu
    Copy the full SHA
    7678c37 View commit details
    Browse the repository at this point in the history

Commits on Dec 4, 2023

  1. Configuration menu
    Copy the full SHA
    e69ce9c View commit details
    Browse the repository at this point in the history

Commits on Dec 7, 2023

  1. Merge pull request arran4#82 from quite/add-component-priority

    Add ComponentPropertyPriority; the VTODO component can have that
    arran4 authored Dec 7, 2023
    Configuration menu
    Copy the full SHA
    aef0a29 View commit details
    Browse the repository at this point in the history

Commits on Dec 18, 2023

  1. Add {Get,Set}LastModifiedAt

    Adding some helpers for parsing another timestamp field. I originally considered exposing `getTimeProp` as `ParseTimeProp`, but the ergonomics are weird enough (is the prop nil? should it be all-day-able?) that I decided against it.
    bcspragu committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    8525f6b View commit details
    Browse the repository at this point in the history

Commits on Dec 20, 2023

  1. Merge pull request arran4#83 from bcspragu/last-modified

    Add {Get,Set}LastModifiedAt helpers
    arran4 authored Dec 20, 2023
    Configuration menu
    Copy the full SHA
    1a61754 View commit details
    Browse the repository at this point in the history

Commits on Jan 8, 2024

  1. Merge remote-tracking branch 'origin/pull-66-add-todo-journal-orphan'…

    … into pull-66-add-todo-journal
    
    * origin/pull-66-add-todo-journal-orphan:
      Add changes for All Day Events to All Day Todos
      Add Comment and Category Properties to Components
      Fix Typos in a couple places
      Add Alarm, Timezone, and FreeBusy Property Methods
      Add Todo and Journal Property Methods
    
    # Conflicts:
    #	calendar.go
    #	components.go
    arran4 committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    a55aac2 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    5f3bef9 View commit details
    Browse the repository at this point in the history
  3. Consistent todo receiver

    arran4 committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    55df13e View commit details
    Browse the repository at this point in the history
  4. Ignore explicitly

    arran4 committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    9e30bdf View commit details
    Browse the repository at this point in the history
  5. Consistent receivers.

    arran4 committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    1e96c15 View commit details
    Browse the repository at this point in the history
  6. Ignore explicitly

    arran4 committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    cf8d1b3 View commit details
    Browse the repository at this point in the history
  7. Merge pull request arran4#84 from arran4/pull-66-add-todo-journal

    Pull 66 add todo journal
    arran4 authored Jan 8, 2024
    Configuration menu
    Copy the full SHA
    804f4d3 View commit details
    Browse the repository at this point in the history

Commits on Jan 27, 2024

  1. Configuration menu
    Copy the full SHA
    681cc6e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    3631125 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    a8f0586 View commit details
    Browse the repository at this point in the history

Commits on Jan 28, 2024

  1. Configuration menu
    Copy the full SHA
    46e2a5c View commit details
    Browse the repository at this point in the history
  2. Merge pull request arran4#85 from brackendawson/panic

    Fix several panics in ParseCalendar
    arran4 authored Jan 28, 2024
    Configuration menu
    Copy the full SHA
    51fa6f1 View commit details
    Browse the repository at this point in the history

Commits on Feb 9, 2024

  1. fix: only escape property values when serializing.

    This commit normalizes the meaning of "property.Value". It always contains an unserialized property value.
    Previously, property params were deserialized when parsing but not serialized again.
    frereit committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    3ffa099 View commit details
    Browse the repository at this point in the history
  2. fix: reorder string replaces in escaping values.

    Previously, ";" was incorrectly escaped. First, ";" was replaced by
    "\;". Then, the backslash was escpaed to "\\", resulting in "\\;".
    
    Now, we first escape all backslashes and then escape other characters.
    frereit committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    0f8a325 View commit details
    Browse the repository at this point in the history

Commits on Feb 14, 2024

  1. Configuration menu
    Copy the full SHA
    647cf9e View commit details
    Browse the repository at this point in the history
  2. Merge pull request arran4#86 from JM-Lemmi/fix/text_escaping

    Fix various text escaping issues
    arran4 authored Feb 14, 2024
    Configuration menu
    Copy the full SHA
    542d6e5 View commit details
    Browse the repository at this point in the history

Commits on Feb 15, 2024

  1. Configuration menu
    Copy the full SHA
    7bd8708 View commit details
    Browse the repository at this point in the history
  2. Revert "fix: only escape property values when serializing."

    This reverts commit 3ffa099.
    frereit committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    bb39d64 View commit details
    Browse the repository at this point in the history
  3. Merge pull request arran4#87 from JM-Lemmi/fix/text_escaping

    Revert incorrect text escaping patch.
    arran4 authored Feb 15, 2024
    Configuration menu
    Copy the full SHA
    0fcebed View commit details
    Browse the repository at this point in the history

Commits on Feb 27, 2024

  1. Configuration menu
    Copy the full SHA
    f5b4408 View commit details
    Browse the repository at this point in the history

Commits on Mar 4, 2024

  1. Configuration menu
    Copy the full SHA
    93ca35f View commit details
    Browse the repository at this point in the history
  2. Merge pull request arran4#88 from meain/org-mailto

    Prefix mailto: for email in organizer property
    arran4 authored Mar 4, 2024
    Configuration menu
    Copy the full SHA
    84a339a View commit details
    Browse the repository at this point in the history

Commits on Apr 11, 2024

  1. Configuration menu
    Copy the full SHA
    02c6335 View commit details
    Browse the repository at this point in the history
  2. Merge pull request arran4#90 from zachmann/master

    Re-add Calendar.RemoveEvent method
    arran4 authored Apr 11, 2024
    Configuration menu
    Copy the full SHA
    9fab3f0 View commit details
    Browse the repository at this point in the history

Commits on May 21, 2024

  1. add: contributing.md

    brenank committed May 21, 2024
    Configuration menu
    Copy the full SHA
    1e5b6e4 View commit details
    Browse the repository at this point in the history
  2. fix: simplify & update ghas

    brenank committed May 21, 2024
    Configuration menu
    Copy the full SHA
    27bb2dd View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    909bd3b View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    3e4aba3 View commit details
    Browse the repository at this point in the history
  5. Merge pull request arran4#92 from brenank/brenank/update-golang

    Update Golang & GHAs
    arran4 authored May 21, 2024
    Configuration menu
    Copy the full SHA
    f044c04 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    008589d View commit details
    Browse the repository at this point in the history
  7. add: serialiation test

    brenank committed May 21, 2024
    Configuration menu
    Copy the full SHA
    baa1c1d View commit details
    Browse the repository at this point in the history
  8. fix: VFREEBUSY serialization

    brenank committed May 21, 2024
    Configuration menu
    Copy the full SHA
    ea37e62 View commit details
    Browse the repository at this point in the history
  9. breaking: unescape Property.Value of type TEXT

    This is a breaking change. Property.Value of value-type: TEXT is now unescaped in the deserialized model. Previously, this was escaped.
    brenank committed May 21, 2024
    Configuration menu
    Copy the full SHA
    8d1cec9 View commit details
    Browse the repository at this point in the history
  10. refactor: fix linting errors

    brenank committed May 21, 2024
    Configuration menu
    Copy the full SHA
    68b453c View commit details
    Browse the repository at this point in the history

Commits on May 30, 2024

  1. Configuration menu
    Copy the full SHA
    b866620 View commit details
    Browse the repository at this point in the history
  2. refactor: switch syntax

    brenank committed May 30, 2024
    Configuration menu
    Copy the full SHA
    2f726f2 View commit details
    Browse the repository at this point in the history
  3. fix: add test err assertion

    brenank committed May 30, 2024
    Configuration menu
    Copy the full SHA
    9a99514 View commit details
    Browse the repository at this point in the history
  4. fix: reduce build restriction on serialization test

    certain os methods were introduced in go1.16
    brenank committed May 30, 2024
    Configuration menu
    Copy the full SHA
    20061ba View commit details
    Browse the repository at this point in the history
  5. Merge pull request arran4#91 from brenank/master

    Unescape Value-Type: TEXT in Golang Model
    arran4 authored May 30, 2024
    Configuration menu
    Copy the full SHA
    6591742 View commit details
    Browse the repository at this point in the history

Commits on Jul 10, 2024

  1. Configuration menu
    Copy the full SHA
    c331f7a View commit details
    Browse the repository at this point in the history
  2. Merge pull request arran4#94 from quite/add-component-relatedto

    Add ComponentPropertyRelatedTo; the VTODO component can have that
    arran4 authored Jul 10, 2024
    Configuration menu
    Copy the full SHA
    ea4ce01 View commit details
    Browse the repository at this point in the history

Commits on Sep 25, 2024

  1. fixed merge conflicts

    ManoloTonto1 committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    f76e1f3 View commit details
    Browse the repository at this point in the history
  2. fixed some namings

    ManoloTonto1 committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    e616cd6 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    2520cb0 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    4c3688b View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2024

  1. Some suggestions, this could be improved still. (#1)

    * Add leaks and vunerability checks
    
    * Requires secrets now
    
    * Renamed interface as it's useful own it's own. Made it public. Added a comment
    
    * Some suggestions, this could be improved still.
    
    * Version bump required by this change.
    
    * 19 too fails.
    
    * Should be able to distinguish unset from invalid time properties
    
    * Improve error for property not found
    
    Co-authored-by: Arran Ubels <[email protected]>
    
    * Remove deprecated ioutil
    
    * Move targeted Go version to 1.20
    
    And test the target forever
    
    * Add method to remove property
    
    Fixes arran4#95
    
    * Merged
    
    * New tool
    
    * Test fixed.
    
    * Fixed test failure. (Error wrapping needed to be considered in EOF checks.)
    
    * %s => %w fixes and an additional error.
    
    ---------
    
    Co-authored-by: Bracken Dawson <[email protected]>
    Co-authored-by: Daniel Lublin <[email protected]>
    3 people authored Oct 4, 2024
    Configuration menu
    Copy the full SHA
    1d9da2e View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2024

  1. Error handling conflicts again (#2)

    * Add leaks and vunerability checks
    
    * Requires secrets now
    
    * Renamed interface as it's useful own it's own. Made it public. Added a comment
    
    * fix: omit zone in "AllDay" event helpers
    
    For a date-only event (i.e., an event that lasts for the full day) the
    iCalendar specification indicates that the value for DTSTART / DTEND
    should be a DATE
    
    https://icalendar.org/iCalendar-RFC-5545/3-6-1-event-component.html
    
    > The "VEVENT" is also the calendar component used to specify an
    > anniversary or daily reminder within a calendar. These events have a
    > DATE value type for the "DTSTART" property instead of the default value
    > type of DATE-TIME. If such a "VEVENT" has a "DTEND" property, it MUST be
    > specified as a DATE value also
    
    The DATE format
    (https://icalendar.org/iCalendar-RFC-5545/3-3-4-date.html) should omit
    both time and zone/location elements and additionally notes that "The
    "TZID" property parameter MUST NOT be applied to DATE properties"
    
    As per the specification, this PR also adds an explicit "VALUE=DATE"
    parameter when the AllDay helpers were called, to indicate that the
    property's default value type has been overridden and the VEVENT is
    intended to be an all-day event
    https://icalendar.org/iCalendar-RFC-5545/3-2-20-value-data-types.html
    
    Finally the SetDuration call has been updated to preserve the "AllDay"
    characteristics if the existing start or end has been specified in DATE
    format, which is also a requirement of the spec.
    
    Contributes-to: arran4#55
    
    * calendar parsing url support
    
    * usage example, README
    
    * added functionnal option pattern for url parsing
    
    * Should be able to distinguish unset from invalid time properties
    
    * Improve error for property not found
    
    Co-authored-by: Arran Ubels <[email protected]>
    
    * Remove deprecated ioutil
    
    * Move targeted Go version to 1.20
    
    And test the target forever
    
    * Add method to remove property
    
    Fixes arran4#95
    
    * Merged
    
    * New tool
    
    * Reintegration of arran4#67
    
    * Resynced and moved some functions around arran4#78
    
    * Test fixed.
    
    * Create bug.md
    
    * Create other.md
    
    * Create default.md
    
    * Rename default.md to pull_request_template.md
    
    * Minor update
    
    * refactor: remove unnecessary named return values, harmonizing code base
    
    * refactor: rename var to reflect what it is
    
    These functions take optional variadic PropertyParam arguments, in ical
    speak they are not properties, but parameters for a property.
    
    * refactor: use ReplaceAll
    
    * refactor: prefer switch for readability
    
    * refactor: use consistent receiver names
    
    * refactor: rename unused arg as '_'
    
    * Tests added.
    
    * Some larger upgrades.
    
    * Fix
    
    * Some multiple-ness.
    
    * Duplication issue fixed.
    
    * Merged
    
    * Merge remote-tracking branch 'origin/master' into issue97
    
    * origin/master:
      Duplication issue fixed.
      Some multiple-ness.
      Test fixed.
      Resynced and moved some functions around arran4#78
      added functionnal option pattern for url parsing
      usage example, README
      calendar parsing url support
    
    # Conflicts:
    #	calendar.go
    #	calendar_test.go
    #	components.go
    
    ---------
    
    Co-authored-by: Dominic Evans <[email protected]>
    Co-authored-by: tradulescu <[email protected]>
    Co-authored-by: Bracken Dawson <[email protected]>
    Co-authored-by: Daniel Lublin <[email protected]>
    5 people authored Oct 21, 2024
    Configuration menu
    Copy the full SHA
    3a306dd View commit details
    Browse the repository at this point in the history