Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Enum classes and their inheritance #243

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

roaffix
Copy link
Contributor

@roaffix roaffix commented Nov 14, 2020

  • Remove the check for enum import.
    Motivation: check for enum's import error is unnecessary on modern python versions because its built-in library is available with a basic python build version. It is pointless to cover very-very-very situational python builds that could not contain enum in it.
  • Remove the C++ style formatting for constants declaration.
    Motivation: FYI, @syurkevi : https://www.python.org/dev/peps/pep-0008/#other-recommendations. Especially example before link that is under "More than one space around an assignment (or other) operator to align it with another" and highlighted "never use more than one space" 🖕 😎
  • Remove wrap for Enum constants with _Enum_Type function.
    Motivation: There is no point to use such a method like _Enum_Type that returns the arg as it is passed into it.
  • to_str is moved to the "library" module to avoid circular import with the "util" module.
    Note: This change does not break the public API because it is still declared in __init__.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant