forked from kubeflow/manifests
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Update manifests wrt kubeflow/pipelines#4723
* Update apiserver role to allow creating SubjectAccessReviews * Add roles which get aggregated to kubeflow-view and kubeflow-edit Original PR: kubeflow/pipelines#4723 Signed-off-by: Ilias Katsakioris <[email protected]>
- Loading branch information
Showing
7 changed files
with
252 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,114 @@ | ||
| # NOTE: IMPORTANT | ||
| # We need to separate out actual rules from aggregation rules due to | ||
| # https://github.com/kubernetes/kubernetes/issues/65171 | ||
| # TL;DR: We can't have both aggregation and rules in a [Cluster]Role. When that | ||
| # is the case, the rules get ignored. | ||
| --- | ||
| apiVersion: rbac.authorization.k8s.io/v1 | ||
| kind: ClusterRole | ||
| metadata: | ||
| labels: | ||
| rbac.authorization.kubeflow.org/aggregate-to-kubeflow-edit: "true" | ||
| name: kubeflow-pipeline-edit | ||
| aggregationRule: | ||
| clusterRoleSelectors: | ||
| - matchLabels: | ||
| rbac.authorization.kubeflow.org/aggregate-to-kubeflow-pipeline-edit: "true" | ||
| rules: [] | ||
|
|
||
| --- | ||
|
|
||
| apiVersion: rbac.authorization.k8s.io/v1 | ||
| kind: ClusterRole | ||
| metadata: | ||
| labels: | ||
| rbac.authorization.kubeflow.org/aggregate-to-kubeflow-pipeline-edit: "true" | ||
| rbac.authorization.kubeflow.org/aggregate-to-kubeflow-view: "true" | ||
| name: kubeflow-pipeline-view | ||
| aggregationRule: | ||
| clusterRoleSelectors: | ||
| - matchLabels: | ||
| rbac.authorization.kubeflow.org/aggregate-to-kubeflow-pipeline-view: "true" | ||
| rules: [] | ||
|
|
||
| --- | ||
|
|
||
| apiVersion: rbac.authorization.k8s.io/v1 | ||
| kind: ClusterRole | ||
| metadata: | ||
| labels: | ||
| rbac.authorization.kubeflow.org/aggregate-to-kubeflow-pipeline-edit: "true" | ||
| name: aggregate-to-pipeline-edit | ||
| rules: | ||
| - apiGroups: | ||
| - pipelines.kubeflow.org | ||
| resources: | ||
| - pipelines | ||
| - pipelines/versions | ||
| verbs: | ||
| - create | ||
| - delete | ||
| - apiGroups: | ||
| - pipelines.kubeflow.org | ||
| resources: | ||
| - experiments | ||
| verbs: | ||
| - archive | ||
| - create | ||
| - delete | ||
| - unarchive | ||
| - apiGroups: | ||
| - pipelines.kubeflow.org | ||
| resources: | ||
| - runs | ||
| verbs: | ||
| - archive | ||
| - create | ||
| - delete | ||
| - retry | ||
| - terminate | ||
| - unarchive | ||
| - apiGroups: | ||
| - pipelines.kubeflow.org | ||
| resources: | ||
| - jobs | ||
| verbs: | ||
| - create | ||
| - delete | ||
| - disable | ||
| - enable | ||
|
|
||
| --- | ||
|
|
||
| apiVersion: rbac.authorization.k8s.io/v1 | ||
| kind: ClusterRole | ||
| metadata: | ||
| labels: | ||
| rbac.authorization.kubeflow.org/aggregate-to-kubeflow-pipeline-view: "true" | ||
| name: aggregate-to-pipeline-view | ||
| rules: | ||
| - apiGroups: | ||
| - pipelines.kubeflow.org | ||
| resources: | ||
| - pipelines | ||
| - pipelines/versions | ||
| - experiments | ||
| - runs | ||
| - jobs | ||
| verbs: | ||
| - get | ||
| - list | ||
| - apiGroups: | ||
| - kubeflow.org | ||
| resources: | ||
| - viewers | ||
| verbs: | ||
| - create | ||
| - get | ||
| - delete | ||
| - apiGroups: | ||
| - pipelines.kubeflow.org | ||
| resources: | ||
| - visualizations | ||
| verbs: | ||
| - create |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 4 additions & 0 deletions
4
pipeline/upstream/base/pipeline/multi-user/kustomization.yaml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| apiVersion: kustomize.config.k8s.io/v1beta1 | ||
| kind: Kustomization | ||
| resources: | ||
| - view-edit-roles.yaml |
114 changes: 114 additions & 0 deletions
114
pipeline/upstream/base/pipeline/multi-user/view-edit-roles.yaml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,114 @@ | ||
| # NOTE: IMPORTANT | ||
| # We need to separate out actual rules from aggregation rules due to | ||
| # https://github.com/kubernetes/kubernetes/issues/65171 | ||
| # TL;DR: We can't have both aggregation and rules in a [Cluster]Role. When that | ||
| # is the case, the rules get ignored. | ||
| --- | ||
| apiVersion: rbac.authorization.k8s.io/v1 | ||
| kind: ClusterRole | ||
| metadata: | ||
| labels: | ||
| rbac.authorization.kubeflow.org/aggregate-to-kubeflow-edit: "true" | ||
| name: kubeflow-pipeline-edit | ||
| aggregationRule: | ||
| clusterRoleSelectors: | ||
| - matchLabels: | ||
| rbac.authorization.kubeflow.org/aggregate-to-kubeflow-pipeline-edit: "true" | ||
| rules: [] | ||
|
|
||
| --- | ||
|
|
||
| apiVersion: rbac.authorization.k8s.io/v1 | ||
| kind: ClusterRole | ||
| metadata: | ||
| labels: | ||
| rbac.authorization.kubeflow.org/aggregate-to-kubeflow-pipeline-edit: "true" | ||
| rbac.authorization.kubeflow.org/aggregate-to-kubeflow-view: "true" | ||
| name: kubeflow-pipeline-view | ||
| aggregationRule: | ||
| clusterRoleSelectors: | ||
| - matchLabels: | ||
| rbac.authorization.kubeflow.org/aggregate-to-kubeflow-pipeline-view: "true" | ||
| rules: [] | ||
|
|
||
| --- | ||
|
|
||
| apiVersion: rbac.authorization.k8s.io/v1 | ||
| kind: ClusterRole | ||
| metadata: | ||
| labels: | ||
| rbac.authorization.kubeflow.org/aggregate-to-kubeflow-pipeline-edit: "true" | ||
| name: aggregate-to-pipeline-edit | ||
| rules: | ||
| - apiGroups: | ||
| - pipelines.kubeflow.org | ||
| resources: | ||
| - pipelines | ||
| - pipelines/versions | ||
| verbs: | ||
| - create | ||
| - delete | ||
| - apiGroups: | ||
| - pipelines.kubeflow.org | ||
| resources: | ||
| - experiments | ||
| verbs: | ||
| - archive | ||
| - create | ||
| - delete | ||
| - unarchive | ||
| - apiGroups: | ||
| - pipelines.kubeflow.org | ||
| resources: | ||
| - runs | ||
| verbs: | ||
| - archive | ||
| - create | ||
| - delete | ||
| - retry | ||
| - terminate | ||
| - unarchive | ||
| - apiGroups: | ||
| - pipelines.kubeflow.org | ||
| resources: | ||
| - jobs | ||
| verbs: | ||
| - create | ||
| - delete | ||
| - disable | ||
| - enable | ||
|
|
||
| --- | ||
|
|
||
| apiVersion: rbac.authorization.k8s.io/v1 | ||
| kind: ClusterRole | ||
| metadata: | ||
| labels: | ||
| rbac.authorization.kubeflow.org/aggregate-to-kubeflow-pipeline-view: "true" | ||
| name: aggregate-to-pipeline-view | ||
| rules: | ||
| - apiGroups: | ||
| - pipelines.kubeflow.org | ||
| resources: | ||
| - pipelines | ||
| - pipelines/versions | ||
| - experiments | ||
| - runs | ||
| - jobs | ||
| verbs: | ||
| - get | ||
| - list | ||
| - apiGroups: | ||
| - kubeflow.org | ||
| resources: | ||
| - viewers | ||
| verbs: | ||
| - create | ||
| - get | ||
| - delete | ||
| - apiGroups: | ||
| - pipelines.kubeflow.org | ||
| resources: | ||
| - visualizations | ||
| verbs: | ||
| - create |