Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix S3 Upload Errors #338

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

camlyall
Copy link
Contributor

Fixes:
a3m/client/clientScripts/a3m_store_aip.py

  • missing pathlib import
  • missing aip file extension
  • fix and simplify path variable type

a3m/client/clientScripts/verify_aip.py

  • Don't move to completed if S3 enabled

@codecov-commenter
Copy link

codecov-commenter commented Apr 21, 2023

Codecov Report

Merging #338 (7911c20) into main (72c552c) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #338      +/-   ##
==========================================
- Coverage   44.19%   44.17%   -0.02%     
==========================================
  Files         109      109              
  Lines        7442     7445       +3     
  Branches     1122     1123       +1     
==========================================
  Hits         3289     3289              
- Misses       3995     3998       +3     
  Partials      158      158              
Impacted Files Coverage Δ
a3m/client/clientScripts/a3m_store_aip.py 0.00% <0.00%> (ø)
a3m/client/clientScripts/verify_aip.py 0.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@camlyall
Copy link
Contributor Author

@sevein is it necessary to fix the coverage issue?

@sevein
Copy link
Member

sevein commented Apr 25, 2023

You can ignore that. The issue reported by the linter should be fixed though. Thank you.

@sevein
Copy link
Member

sevein commented Apr 26, 2023

@camlyall could you please file issue(s) describing the problems that you're addressing? I'd like to understand the user case and the problems with our use of s3.meta.client.upload_file and and the "completed" directory. Thank you in advance!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants