Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove FITS #1988

Merged
merged 8 commits into from
Sep 11, 2024
Merged

Remove FITS #1988

merged 8 commits into from
Sep 11, 2024

Conversation

replaceafill
Copy link
Member

@replaceafill replaceafill commented Sep 3, 2024 •
edited
Loading

This removes:

  • the fits service and its package dependencies from the Compose environment
  • the FITS_v0.0 client script from the MCPClient and updates the MCPServer workflow to use the identifyFileFormat_v0.0 and characterizeFile_v0.0 scripts for manually normalized preservation files
  • the FPR model instances (FPTool, FPCommand and FPRule) related to FITS with a database data migration in the fpr application of the Dashboard

Connected to archivematica/Issues#703

@replaceafill replaceafill added AMAUAT Issues relating to the improvement of the AM Automated Acceptance tests and removed AMAUAT Issues relating to the improvement of the AM Automated Acceptance tests labels Sep 3, 2024
@replaceafill replaceafill marked this pull request as ready for review September 10, 2024 20:45
@replaceafill replaceafill added AMAUAT Issues relating to the improvement of the AM Automated Acceptance tests and removed AMAUAT Issues relating to the improvement of the AM Automated Acceptance tests labels Sep 10, 2024
@replaceafill replaceafill added AMAUAT Issues relating to the improvement of the AM Automated Acceptance tests and removed AMAUAT Issues relating to the improvement of the AM Automated Acceptance tests labels Sep 10, 2024
@replaceafill replaceafill requested a review from a team September 10, 2024 21:02
sevein
sevein approved these changes Sep 11, 2024
View reviewed changes
Copy link
Member

@sevein sevein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@replaceafill replaceafill merged commit 0212db1 into qa/1.x Sep 11, 2024
46 of 47 checks passed
@replaceafill replaceafill deleted the dev/issue-703-remove-fits branch September 11, 2024 13:41
Dhwaniartefact
Dhwaniartefact reviewed Sep 11, 2024
View reviewed changes
Copy link
Contributor

@Dhwaniartefact Dhwaniartefact left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dhwaniartefact Dhwaniartefact Dhwaniartefact left review comments

@sevein sevein sevein approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@replaceafill @sevein @Dhwaniartefact