Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Escape output and error in launchSubProcess #1990

Merged
merged 4 commits into from
Sep 12, 2024

Conversation

replaceafill
Copy link
Member

This replaces non utf-8 characters with replacement characters when decoding the output and error bytes from subprocess calls in the launchSubProcess function.

Connected to archivematica/Issues#1702

@replaceafill replaceafill added AMAUAT Issues relating to the improvement of the AM Automated Acceptance tests and removed AMAUAT Issues relating to the improvement of the AM Automated Acceptance tests labels Sep 11, 2024
@replaceafill replaceafill added AMAUAT Issues relating to the improvement of the AM Automated Acceptance tests and removed AMAUAT Issues relating to the improvement of the AM Automated Acceptance tests labels Sep 11, 2024
Copy link
Contributor

@Dhwaniartefact Dhwaniartefact left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@replaceafill replaceafill merged commit a78868e into qa/1.x Sep 12, 2024
47 checks passed
@replaceafill replaceafill deleted the dev/issue-1702-fix-decode-error branch September 12, 2024 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants