Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace clamd with clamav-client #1991

Open
wants to merge 3 commits into
base: qa/1.x
Choose a base branch
from

Conversation

sevein
Copy link
Member

@sevein sevein commented Sep 17, 2024

This commit replaces clamd 1.0.2 with clamav-client 0.6.0, a modern fork of
clamd that follows current Python practices and tooling. clamav-client is tested
with supported versions of Python and avoids deprecated dependencies such as
pkg_resources (which was removed in Python 3.12).

clamav-client provides its own Scanner interface to handle integration with
both clamd and clamscan, so Archivematica doesn't need to. Both backends are
tested with integration tests.

This commit replaces [clamd 1.0.2] with [clamav-client 0.6.0], a modern fork of
clamd that follows current Python practices and tooling. clamav-client is tested
with supported versions of Python and avoids deprecated dependencies such as
`pkg_resources` (which was removed in Python 3.12).

clamav-client provides its own `Scanner` interface to handle integration with
both `clamd` and `clamscan`, so Archivematica doesn't need to. Both backends are
tested with integration tests.

[clamd 1.0.2]: https://pypi.org/project/clamd/1.0.2/
[clamav-client 0.6.0]: https://pypi.org/project/clamav-client/0.6.0/
@sevein sevein force-pushed the dev/use-clamav-client-package branch from 64e6d6b to 5e71df3 Compare September 17, 2024 06:04
@sevein sevein requested a review from a team September 17, 2024 06:05
@sevein sevein added the AMAUAT Issues relating to the improvement of the AM Automated Acceptance tests label Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AMAUAT Issues relating to the improvement of the AM Automated Acceptance tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant