Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use timezone aware timestamps for file modification #1992

Merged
merged 3 commits into from
Sep 25, 2024
Merged

Use timezone aware timestamps for file modification #1992

merged 3 commits into from
Sep 25, 2024

Commits on Sep 18, 2024

  1. Extract expected time into separate variable

    @replaceafill
    replaceafill committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    17f1b6a View commit details
    Browse the repository at this point in the history

  2. Update test to use a non UTC time zone 

    This test case represents a time zone and file modification time
combination that makes the job to fail in Archivematica 1.15.x.

In this commit the test fails because the expected time is now time
zone aware but the job has not been updated to use the current time
zone yet.

```console
FAILED test_store_file_modification.py::TestStoreFileModification::test_store_file_modification_dates - AssertionError: assert '2003-04-06 07:59:30+00:00' == '2003-04-06 02:59:30+00:00'

  - 2003-04-06 02:59:30+00:00
  ?             ^
  + 2003-04-06 07:59:30+00:00
  ?             ^
```
    @replaceafill
    replaceafill committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    7d8a3d8 View commit details
    Browse the repository at this point in the history

  3. Update job to create timezone aware timestamps

    @replaceafill
    replaceafill committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    9282a5a View commit details
    Browse the repository at this point in the history