Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Problem: Finding aids pdfs have errors #1746

Closed
anvit opened this issue Jan 30, 2024 · 0 comments · Fixed by #1747
Closed

Problem: Finding aids pdfs have errors #1746

anvit opened this issue Jan 30, 2024 · 0 comments · Fixed by #1747
Assignees
@anvit
Labels
Type: bug A flaw in the code that causes the software to produce an incorrect or unexpected result.
Milestone
2.8.1

Comments

@anvit
Copy link
Contributor

anvit commented Jan 30, 2024 •
edited
Loading

Current Behavior

Steps to reproduce the behavior

  1. Generate finding aids PDFs for an archival description for with a file as it's child containing a general note.
  2. Notice that the Administrative history / Biographical Sketch section has a "Note" subheading in the pdf.
  3. Look for the general note for the file in the pdf. Notice that it says Note [generalNote]:

Expected Behavior

  1. There should not be a note subheading under the administrative history section.
  2. The Note [generalNote] should be Note [General].

Version used

AtoM 2.8.0
@anvit anvit added the Type: bug A flaw in the code that causes the software to produce an incorrect or unexpected result. label Jan 30, 2024
@anvit anvit added this to the 2.8.1 milestone Jan 30, 2024
@anvit anvit self-assigned this Jan 30, 2024
anvit added a commit that referenced this issue Jan 30, 2024
@anvit
Fixes notes related issues in XSLT files (#1746)
f88cbb7 
Fixes a number of XSLT problems:
- Removes "Note" subheading under the bio history section
- Have general notes in files list the name of the type (General)
  instead of the type itself (generalNote)
@anvit anvit linked a pull request Jan 30, 2024 that will close this issue
Fix notes related issues in XSLT files (#1746) #1747
Merged
anvit added a commit that referenced this issue Feb 7, 2024
@anvit
Fix notes related issues in XSLT files (#1746)
e7256c1 
Fixes the following XSLT issues:
- Removes "Note" subheading under the bio history section
- Have general notes in files list the name of the type (General)
  instead of the type itself (generalNote)
anvit added a commit that referenced this issue Feb 16, 2024
@anvit
Fix notes related issues in XSLT files (#1746)
6ef18d0 
Fixes the following XSLT issues:
- Removes "Note" subheading under the bio history section
- Have general notes in files list the name of the type (General)
  instead of the type itself (generalNote)
melaniekung pushed a commit that referenced this issue Mar 14, 2024
@anvit @melaniekung
Fix notes related issues in XSLT files (#1746)
27dee71 
Fixes the following XSLT issues:
- Removes "Note" subheading under the bio history section
- Have general notes in files list the name of the type (General)
  instead of the type itself (generalNote)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@anvit anvit

Labels
Type: bug A flaw in the code that causes the software to produce an incorrect or unexpected result.
Projects
None yet
Milestone
2.8.1
Development

Successfully merging a pull request may close this issue.

Fix notes related issues in XSLT files (#1746) artefactual/atom
1 participant
@anvit