Fix notes related issues in XSLT files (#1746) #1747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anvit
added
Type: bug
anvit
changed the title
Fixes the following XSLT issues: - Removes "Note" subheading under the bio history section - Have general notes in files list the name of the type (General) instead of the type itself (generalNote)
anvit
force-pushed
the
dev/issue-1746-xslt-fixes
branch
from
f88cbb7
to
e7256c1
Compare
jraddaoui
approved these changes
Feb 14, 2024
| </xsl:when> | ||
| <xsl:otherwise> | ||
| <xsl:value-of select="local:tagName(.)"/> | ||
| <xsl:if test="@type"> [<xsl:value-of select="local:typeLabel(.)"/>]</xsl:if> |
There was a problem hiding this comment.
Having a hard time checking these changes, is this the only change here?
There was a problem hiding this comment.
Yup, that's the only actual change here!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the following XSLT issues:
Also split up the formatting code for elements in the collection inventory into multiple lines for readability.