Fix search query special chars (#1605) #1660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anvit
added
the
Type: bug
jraddaoui
approved these changes
Oct 2, 2023
The search query used in the generateQueryString function does not escape special characters specified in the escape_queries setting, and the query provided to it by arElasticSearchPluginQuery has not been previously escaped either. Updating this to call escapeTerm to escape the search query so that this setting is respected.
anvit
force-pushed
the
dev/issue-1605-search-special-chars
branch
from
9929db0
to
f374ec5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The search query used in the
generateQueryStringfunction does not escape special characters specified in the escape_queries setting, and the query provided to it byarElasticSearchPluginQueryhas not been previously escaped either.This seems to have regressed during #1518 and I can't seem to find references to
escapeTermbeing called elsewhere and the search query escaping user provided special characters, so I'm updating this in the generateQueryString function to call escapeTerm to escape the search query so that this setting is respected.If there's a better place to make this function call to pre-escape the query string, let me know.