Fix update function for 'Language and script notes'. (#13657) #1664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
melaniekung
added
Type: bug
melaniekung
force-pushed
the
dev/issue-13657-edit-lang-script-notes
branch
2 times, most recently
from
f26368b
to
9f7b325
Compare
melaniekung
changed the title
melaniekung
force-pushed
the
dev/issue-13657-edit-lang-script-notes
branch
4 times, most recently
from
f356053
to
fec893f
Compare
anvit
reviewed
Sep 28, 2023
melaniekung
force-pushed
the
dev/issue-13657-edit-lang-script-notes
branch
from
fec893f
to
c438925
Compare
anvit
approved these changes
Oct 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug was due to the 'Language and script notes' field being specific to the ISAD, DACS, and RAD templates only, so they were handled differently and was not checking to see if the string/field was updated.
Added a function to check the stored memory to see if notes were updated when duplicating an archival description. This was created specifically for the 'Language and script notes' field, defined by the
QubitTerm::LANGUAGE_NOTE_ID.