Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix npm install for Docker. (#1662) #1665

Merged
merged 1 commit into from
Sep 28, 2023
Merged

Fix npm install for Docker. (#1662) #1665

merged 1 commit into from
Sep 28, 2023

Conversation

melaniekung
Copy link
Contributor

Fix for installing npm on Docker.

@melaniekung melaniekung added Type: bug A flaw in the code that causes the software to produce an incorrect or unexpected result. good first issue An issue that would be easy for someone who has not worked with the codebase/docs before. labels Sep 25, 2023
@melaniekung melaniekung added this to the 2.8.0 milestone Sep 25, 2023
@melaniekung melaniekung self-assigned this Sep 25, 2023
@melaniekung melaniekung requested a review from a team September 25, 2023 15:21
@anvit anvit force-pushed the dev/issue-1662-npm-install-docker branch from 1b3a7f7 to c870de6 Compare September 28, 2023 17:02
anvit
anvit approved these changes Sep 28, 2023
View reviewed changes
Copy link
Contributor

@anvit anvit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍🏼

@melaniekung melaniekung merged commit 43a18e1 into qa/2.x Sep 28, 2023
6 checks passed
@melaniekung melaniekung deleted the dev/issue-1662-npm-install-docker branch September 28, 2023 18:45
@anvit anvit linked an issue Oct 19, 2023 that may be closed by this pull request
Problem: Docker gives an error when it is trying to install a package from npm #1662
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anvit anvit anvit approved these changes

Assignees

@melaniekung melaniekung

Labels
good first issue An issue that would be easy for someone who has not worked with the codebase/docs before. Type: bug A flaw in the code that causes the software to produce an incorrect or unexpected result.
Projects
None yet
Milestone
2.8.0
Development

Successfully merging this pull request may close these issues.

Problem: Docker gives an error when it is trying to install a package from npm
2 participants
@melaniekung @anvit