Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add error handling for tools:rename-slug. (#1666) #1669

Merged
merged 1 commit into from
Sep 28, 2023
Merged

Add error handling for tools:rename-slug. (#1666) #1669

merged 1 commit into from
Sep 28, 2023

Conversation

melaniekung
Copy link
Contributor

@melaniekung melaniekung commented Sep 25, 2023 •
edited
Loading

Add error handling for tools:rename-slug so that if the new slug already exists, the tool will take note and move on, instead of terminating.

Once all the slugs have been updated, it will ouput the following into the command line STDOUT:

  • list each slug that failed to rename
  • provide a log file path listing all successful slug renames

@melaniekung melaniekung self-assigned this Sep 25, 2023
@melaniekung melaniekung added the Type: bug A flaw in the code that causes the software to produce an incorrect or unexpected result. label Sep 25, 2023
@melaniekung melaniekung added this to the 2.8.0 milestone Sep 25, 2023
@melaniekung melaniekung force-pushed the dev/issue-1666-rename-slugs-error-handling branch 2 times, most recently from cb8762e to d9bddad Compare September 25, 2023 21:09
anvit
anvit reviewed Sep 25, 2023
View reviewed changes
lib/task/tools/renameSlugTask.class.php Outdated Show resolved Hide resolved
lib/task/tools/renameSlugTask.class.php Outdated Show resolved Hide resolved
@melaniekung melaniekung force-pushed the dev/issue-1666-rename-slugs-error-handling branch 5 times, most recently from 5a44df2 to c5c9a3b Compare September 28, 2023 18:40
@melaniekung melaniekung force-pushed the dev/issue-1666-rename-slugs-error-handling branch from c5c9a3b to d601420 Compare September 28, 2023 18:44
anvit
anvit approved these changes Sep 28, 2023
View reviewed changes
Copy link
Contributor

@anvit anvit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Nicely done!

@melaniekung melaniekung merged commit 48e1fa3 into qa/2.x Sep 28, 2023
6 checks passed
@melaniekung melaniekung deleted the dev/issue-1666-rename-slugs-error-handling branch September 28, 2023 19:06
@anvit anvit linked an issue Oct 4, 2023 that may be closed by this pull request
Problem: tools:rename-slug: error handling #1666
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anvit anvit anvit approved these changes

Assignees

@melaniekung melaniekung

Labels
Type: bug A flaw in the code that causes the software to produce an incorrect or unexpected result.
Projects
None yet
Milestone
2.8.0
Development

Successfully merging this pull request may close these issues.

Problem: tools:rename-slug: error handling
2 participants
@melaniekung @anvit