Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent addition of incomplete access points. (#1661) #1677

Merged
merged 1 commit into from
Oct 13, 2023

Conversation

melaniekung
Copy link
Contributor

@melaniekung melaniekung commented Oct 11, 2023

Currently, if a user starts to type a term, then decide not to add it and delete the bullet point before saving the archival description, the incomplete term is still saved in the taxonomy.

Expected behaviour is that if the bullet point has been deleted prior to saving, the term should not be saved.

@melaniekung melaniekung added the Type: bug A flaw in the code that causes the software to produce an incorrect or unexpected result. label Oct 11, 2023
@melaniekung melaniekung added this to the 2.8.0 milestone Oct 11, 2023
@melaniekung melaniekung requested a review from a team October 11, 2023 21:03
@melaniekung melaniekung self-assigned this Oct 11, 2023
@melaniekung melaniekung linked an issue Oct 12, 2023 that may be closed by this pull request
Copy link
Contributor

@anvit anvit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@melaniekung melaniekung merged commit 7724729 into qa/2.x Oct 13, 2023
6 checks passed
@melaniekung melaniekung deleted the dev/issue-1661-incomplete-access-points branch October 13, 2023 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: bug A flaw in the code that causes the software to produce an incorrect or unexpected result.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problem: Issue adding access points
2 participants