Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GA4 tracking for fullwidth treeview. (#1606) #1679

Merged
merged 1 commit into from
Oct 16, 2023

Conversation

melaniekung
Copy link
Contributor

With BS5's new fullwidth treeview, GA4 is not tracking any page views triggered via the treeview. We want to add a gtag event to send a page view to GA so that when a user views records using the fullwidth treeview, it can be tracked.

@melaniekung melaniekung added Type: bug A flaw in the code that causes the software to produce an incorrect or unexpected result. work-in-progress labels Oct 13, 2023
@melaniekung melaniekung self-assigned this Oct 13, 2023
@melaniekung melaniekung added this to the 2.8.0 milestone Oct 13, 2023
@melaniekung melaniekung force-pushed the dev/1606-g4-fullwidth-treeview branch 2 times, most recently from c91f13b to 8e4d445 Compare October 13, 2023 16:43
js/fullWidthTreeView.js Outdated Show resolved Hide resolved
plugins/arDominionB5Plugin/js/fullWidthTreeView.js Outdated Show resolved Hide resolved
@melaniekung melaniekung force-pushed the dev/1606-g4-fullwidth-treeview branch 3 times, most recently from 278bb8c to 7d68a35 Compare October 16, 2023 17:09
Bug was a result of fullwidth treeview not updating document title so GA
was receiving incorrect information. Once we updated the document title,
the correct information is sent to GA for tracking.
Copy link
Contributor

@anvit anvit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Glad we finally figured this one out.

@melaniekung melaniekung merged commit 18afdb6 into qa/2.x Oct 16, 2023
6 checks passed
@melaniekung melaniekung deleted the dev/1606-g4-fullwidth-treeview branch October 16, 2023 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: bug A flaw in the code that causes the software to produce an incorrect or unexpected result. work-in-progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problem: G4 analytics does not track pageviews from clicks in full-width treeview
2 participants