Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide informative csrf attack message. (#1678) #1681

Merged
merged 1 commit into from
Oct 16, 2023

Conversation

melaniekung
Copy link
Contributor

Provide a more informative message for resolving Symfony's csrf token message.

Currently, if a user stays logged into AtoM for a long period of time, their csrf token expires. If they try to re-login without refreshing the browser, they get a scary message saying "CSRF attack detected". The token is usually not actually attacked, but expired, so providing a more informative message on how to resolve the issue will address any concerns related to the message.

@melaniekung melaniekung requested a review from a team October 16, 2023 15:08
@melaniekung melaniekung self-assigned this Oct 16, 2023
@melaniekung melaniekung added the Type: enhancement An improvement to existing functionality. label Oct 16, 2023
@melaniekung melaniekung added this to the 2.8.0 milestone Oct 16, 2023
Copy link
Contributor

@anvit anvit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@anvit anvit linked an issue Oct 16, 2023 that may be closed by this pull request
@melaniekung melaniekung merged commit e9bb689 into qa/2.x Oct 16, 2023
6 checks passed
@melaniekung melaniekung deleted the dev/issue-1678-crsf-attack-msg branch October 16, 2023 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: enhancement An improvement to existing functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CSRF Attack message
2 participants