Allow selection of secondary OIDC provider #1824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbreker
force-pushed
the
dev/oidc-allow-secondary-provider
branch
from
3e0b828
to
34c1f5a
Compare
anvit
requested changes
Jun 19, 2024
| { | ||
| $authenticated = false; | ||
| $user = null; | ||
| $authenticateResult = false; | ||
| $email = null; | ||
|
|
||
| $this->logger->err(sprintf('%s', json_encode(sfConfig::getAll()))); |
There was a problem hiding this comment.
Yes it is! 😆 🤦
Thanks for catching this! 👍
There was a problem hiding this comment.
Removed - see latest commit
| } catch (Exception $e) { | ||
| $this->setProviderId(); |
There was a problem hiding this comment.
Is this repeated function call inside the catch a typo?
There was a problem hiding this comment.
I was trying to ensure that setProviderId() would be run even if there was an exception generated in signOut().
I am wondering now if I could just move getSessionProviderID() and setProviderId() to before the try{}. I will have a closer look.
There was a problem hiding this comment.
Updated and tested. See latest commit.
sbreker
force-pushed
the
dev/oidc-allow-secondary-provider
branch
from
6b0d6fa
to
0d11646
Compare
sbreker
force-pushed
the
dev/oidc-allow-secondary-provider
branch
from
0d11646
to
f813789
Compare
Add the ability to define a secondary OIDC provider for authentication and select it using a query param on the request URL. E.g. Use the 'sample_provider' provider by modifying the AtoM URL before pressing "Log in with SSO": http://127.0.0.1:63001/index.php?secondary=sample_provider
sbreker
force-pushed
the
dev/oidc-allow-secondary-provider
branch
from
f813789
to
52d7f01
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the ability to define a secondary OIDC provider for authentication and select it using a query param on the request URL.
E.g. Use the 'sample_provider' provider by modifying the AtoM URL before pressing "Log in with SSO":
http://127.0.0.1:63001/index.php?secondary=sample_provider