Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the contrast #1840

Conversation

eviau-artefactual
Copy link
Contributor

@eviau-artefactual eviau-artefactual commented Jul 16, 2024

As part of #1509

I chose the colour by using a darker shade of orange: #c44e00 instead of #f60.

We can pick another colour - I only tested on Firefox using the integrated accessibility tools.

If my understanding of SCSS is correct, this should build correctly, given that I am unable to build and access this version to test it locally with Docker, following the instructions in https://www.accesstomemory.org/fr/docs/2.8/dev-manual/env/compose/ ... do these docs needs a review ?

@anvit
Copy link
Contributor

anvit commented Jul 17, 2024

The change looks good to me, but tagging @fiver-watson in case there were historical branding or UX reasons for sticking to that specific shade of orange that I might not be aware of.

@anvit anvit requested a review from fiver-watson July 17, 2024 23:19
@fiver-watson
Copy link
Contributor

fiver-watson commented Jul 18, 2024

Looks okay to me, and seems to meet WCG AA requirements:

atom-orange-contrast-check-black

Note: it would be good to double-check, but looking through the demo site, I couldn't actually find places where we use small black text on an orange background, so I'm not too concerned about this result. In general, we use orange text on white backgrounds, or the opposite:

atom-orange-contrast-check-white
atom-orange-contrast-check-white-bg

(sidenote, I don't think we will ever achieve AAA compliance in the base theme. Instead, I have always thought that instead of the ArchivesCanada theme as a secondary theme, we should have an accessibility-focused second theme, that includes high contrast color changes, built-in buttons to resize page text, etc... but that's a whole separate thing).

Additionally, AFAIK we already are not using the same orange as Artefactual has used elsewhere in its branding. The Circle-A logo appears to use #F56400; the AtoM logo used in the header of AtoM itself uses #FF6600; the Artefactual logo used in the header of the company website looks like the A is using #F36F2B; the Arty logo showing in place of Donald's face in the Teams section of the website uses #F46400, etc....

You could always check with BUD but so far, we have definitely NOT been consistent in our use of orange in our branding, so personally I think that adjusting this color to better support contrast for accessibility is totally fine!

@eviau-artefactual eviau-artefactual merged commit 88b41d0 into artefactual:qa/2.x Jul 30, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants