Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CONTRIBUTING.md #1848

Merged

Conversation

eviau-artefactual
Copy link
Contributor

@eviau-artefactual eviau-artefactual commented Jul 23, 2024

This update should reflect changes to the process.

It also contains some rephrasing, for concision.

Suggestions are welcome on how this could be further improved.
As an example, I find this paragraph to be a bit... tedious?

If nothing comes up, start a conversation by opening a new thread
on the user forum. When your bug will have been better understood,
you may be invited to open an issue on GitHub.

Copy link
Contributor

@fiver-watson fiver-watson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have added a couple suggestions, for that one sentence but also as general considerations about some of the changes and the links. You may have already considered these things (in which case ignore); for now just ensuring that we are not implying promises we don't intend to keep.

Otherwise, LGTM!

CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Show resolved Hide resolved
CONTRIBUTING.md Show resolved Hide resolved
Copy link
Contributor

@melaniekung melaniekung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi edith, added a couple comments but otherwise, looks good to me! thank you for addressing this :)

CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Show resolved Hide resolved
CONTRIBUTING.md Show resolved Hide resolved
Copy link
Contributor

@fiver-watson fiver-watson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@eviau-artefactual eviau-artefactual merged commit 44a2b76 into artefactual:qa/2.x Jul 31, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants