-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update CONTRIBUTING.md #1848
Update CONTRIBUTING.md #1848
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have added a couple suggestions, for that one sentence but also as general considerations about some of the changes and the links. You may have already considered these things (in which case ignore); for now just ensuring that we are not implying promises we don't intend to keep.
Otherwise, LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hi edith, added a couple comments but otherwise, looks good to me! thank you for addressing this :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
This update should reflect changes to the process.
It also contains some rephrasing, for concision.
Suggestions are welcome on how this could be further improved.
As an example, I find this paragraph to be a bit... tedious?