Ignore newlines in CSP directive in app.yml #1857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbreker
force-pushed
the
dev/add-csp-filter-test
branch
2 times, most recently
from
244e1e5
to
3abd892
Compare
sbreker
force-pushed
the
dev/add-csp-filter-test
branch
from
3abd892
to
8b6765d
Compare
This commit adds logic to QubitCspFilter to ignore newlines added when defining the CSP Directive in app.yml. Refactor QubitCspFilter to move config reading logic to separate methods in the QubitCspFilter class. Add tests to ensure that the config vars are read correctly from app.yml when they are formatted in different ways.
sbreker
force-pushed
the
dev/add-csp-filter-test
branch
from
8b6765d
to
d00c51b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds logic to QubitCspFilter to ignore newlines added when defining the CSP Directive in app.yml.
Refactor QubitCspFilter to move config reading logic to separate methods in the QubitCspFilter class.
Add tests to ensure that the config vars are read correctly from app.yml when they are formatted in different ways.