Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update institution upload limits. (#1864) #1875

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

melaniekung
Copy link
Contributor

@melaniekung melaniekung commented Sep 26, 2024

Clarify that 'Archival Institution upload limits' setting is to enable/disable the meter display. Implement 'Default Archival Institution upload limit' setting of '-1' to enable unlimited uploads for all Archival Institutions.

@melaniekung melaniekung force-pushed the dev/issue-1864-repository-upload-limit-disabled branch 2 times, most recently from 981821d to ef121f9 Compare September 26, 2024 18:35
@melaniekung melaniekung changed the title Fix disable per institution upload limits. (#1864) Update institution upload limits. (#1864) Sep 26, 2024
@melaniekung melaniekung requested review from fiver-watson and a team September 26, 2024 18:42
Copy link
Contributor

@fiver-watson fiver-watson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I..... can't evaluate the code, but I see this relates to #1864, and the proposed tooltip wording change here looks good to me

@melaniekung
Copy link
Contributor Author

thanks @fiver-watson , just wanted your opinion on the change in functionality is all :)

Copy link
Contributor

@anvit anvit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @melaniekung ! Looks good

@melaniekung melaniekung merged commit ac57193 into qa/2.x Oct 15, 2024
6 checks passed
@melaniekung melaniekung deleted the dev/issue-1864-repository-upload-limit-disabled branch October 15, 2024 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants