Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unit test coverage for AtoM OIDC Plugin #1877

Closed
wants to merge 6 commits into from
Closed

Add unit test coverage for AtoM OIDC Plugin #1877

wants to merge 6 commits into from

Conversation

sbreker
Copy link
Member

@sbreker sbreker commented Oct 2, 2024

No description provided.

@sbreker
Remove OIDC plugin getOidcInstance check
98d7339 
Removed unnecessary instance check in arOidc::getOidcInstance(). This
check was broken in that if it were called a second time
getOidcInstance() would return null.
@sbreker sbreker force-pushed the dev/oidc-tests branch 9 times, most recently from 890bf9e to 430dedc Compare October 4, 2024 20:26
@sbreker
Add oidcUser test with mock OpenIDConnectClient
2111cbe 
Test oidcUser::authenticate() method with mock OpenIDConnectClient.

Modify phpunit.xml to set phpunit option 'stderr' to "true". This
prevents error messages when tests call the setcookie() function.
@sbreker sbreker force-pushed the dev/oidc-tests branch 10 times, most recently from 823408d to 35d78ab Compare October 9, 2024 22:33
@sbreker sbreker force-pushed the dev/oidc-tests branch 2 times, most recently from 5ea40b4 to bf4b741 Compare October 10, 2024 00:32
@sbreker sbreker closed this Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
work-in-progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@sbreker