feat(DIA-927): conditionally display email enrollment checkbox during sign-up #11020
Conversation
| isAutomaticallySubscribed, | ||
| loading, | ||
| } | ||
| } |
|
|
||
| // TODO: Show a skeleton loader | ||
| if (loading) { | ||
| return null |
There was a problem hiding this comment.
This is the sort of thing where we should avoid using a skeleton because its so conditional. For most users, this just wont appear and we can probably just have it pop in. But def play with it! might be able to make it nice.
There was a problem hiding this comment.
Sounds good. Thanks!
|
|
||
| describe("user is automatically subscribed", () => { | ||
| beforeEach(() => { | ||
| ;(useCountryCode as jest.Mock).mockReturnValue({ |
There was a problem hiding this comment.
this is non-blocking, but in future code its helpful for future updates to do something like:
const mockUseCountryCode = useCountryCode as jest.Mockup at the top
There was a problem hiding this comment.
I'll make that change while I'm at it now 👍
| @@ -21,5 +21,5 @@ appId: ${MAESTRO_APP_ID} | |||
| when: | |||
| platform: Android | |||
| commands: | |||
| - tapOn: "checkbox of consent, Check this element to consent with the Terms of Service" | |||
| - tapOn: "Accept terms and privacy policy, Check this element to accept Artsy's terms and privacy policy" | |||
There was a problem hiding this comment.
@araujobarret do you know what this file is for?
There was a problem hiding this comment.
old stuff before maestro cloud, was supposed to be used in automation, I have to clean that up
There was a problem hiding this comment.
I think this file was related to our test of a new E2E tool that we've abandoned. @brainbicycle / @gkartalis - right?
There was a problem hiding this comment.
this one is @araujobarret work on their main offering which is more standard e2e tests, we might start looking into it again at some point but feel free to delete we can always bring it back
iskounen
deleted the
iskounen/feat/conditionally-display-email-checkbox
branch
This PR resolves DIA-927
Description
This PR updates the auth2 sign-up flow to conditionally display a checkbox that users can check to enroll in email subscriptions depending on whether it is required or not.
PR Checklist
To the reviewers 👀
Changelog updates
Changelog updates
Cross-platform user-facing changes
iOS user-facing changes
Android user-facing changes
Dev changes
Need help with something? Have a look at our docs, or get in touch with us.