feat: add signed as filter param to filterArtworksConnection #15111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MounirDhahri
force-pushed
the
feat/add-framed-signed-filter
branch
3 times, most recently
from
d8212a1 to
a1dbf88
Compare
#1604 Bundle Size — 9MiB (-0.03%).c09ef12(current) vs 8e18ff5 main#1603(baseline) Warning Bundle contains 14 duplicate packages – View duplicate packages Bundle metrics
|
| Current #1604 |
Baseline #1603 |
|
|---|---|---|
 Initial JS |
3.65MiB(+0.02%) |
3.65MiB |
 Initial CSS |
0B |
0B |
 Cache Invalidation |
55.69% |
39.05% |
| Chunks |
105(+0.96%) |
104 |
| Assets |
108(+0.93%) |
107 |
| Modules |
5848(-0.12%) |
5855 |
 Duplicate Modules |
523(-1.51%) |
531 |
| Duplicate Code |
4.01%(-1.47%) |
4.07% |
| Packages |
266 |
266 |
| Duplicate Packages |
13 |
13 |
Bundle size by type 2 changes 1 regression 1 improvement
| Current #1604 |
Baseline #1603 |
|
|---|---|---|
| JS |
8.86MiB (-0.05%) |
8.86MiB |
| Other |
147.32KiB (+1.44%) |
145.23KiB |
Bundle analysis report Branch feat/add-framed-signed-filter Project dashboard
Generated by RelativeCI Documentation Report issue
anandaroop
reviewed
Jan 23, 2025
| // but NOT as an alert criterion, so we remove it. | ||
| // (Alerts, by definition, stipulate forSale=true | ||
| // when they are created in Gravity.) | ||
| delete criteria.forSale | ||
| delete criteria.signed |
MounirDhahri
force-pushed
the
feat/add-framed-signed-filter
branch
from
a1dbf88 to
c09ef12
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The type of this PR is: feat
This PR adds signed as a filter param to
filterArtworksConnectionRelated PRs artsy/metaphysics#6382 and https://github.com/artsy/gravity/pull/18512