Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix single quotes dropped #155

Merged
merged 4 commits into from
Nov 17, 2024
Merged

Fix single quotes dropped #155

merged 4 commits into from
Nov 17, 2024

Conversation

Greendor1234
Copy link
Contributor

To close issue #151

According to what it's written in the comments, I introduced a regular expression that replaces the quotes for anything with {{}}.

I checked the results, it seems to work.

Copy link
Owner

@arttor arttor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks really good, thank you for adjusting test examples. I had only one comment related to unit tests.

pkg/processor/deployment/deployment.go Outdated Show resolved Hide resolved
@Greendor1234
Copy link
Contributor Author

I added all the edge cases that came to my mind

@arttor arttor merged commit 1e2ec17 into arttor:main Nov 17, 2024
1 check passed
@arttor
Copy link
Owner

arttor commented Nov 17, 2024

@Greendor1234 thank you for your contribution. The changes are available in v0.4.15 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants