Gradle 6.0 and Property API's #76
Conversation
AGP 3.5.2 gradle task config avoidance. closes arturdm#66 *breaking changes to config DSL use a "reports/jacoco/unitTest/variant/flavor/type" convention similar to a vanilla java project so that the outputs do not overlap with variants or other coverage reports external to this plugin. makes plugin application order non critical
Codecov Report
@@ Coverage Diff @@
## master #76 +/- ##
============================================
+ Coverage 88.46% 95.83% +7.37%
+ Complexity 24 12 -12
============================================
Files 3 2 -1
Lines 78 72 -6
Branches 11 2 -9
============================================
Hits 69 69
- Misses 2 3 +1
+ Partials 7 0 -7
Continue to review full report at Codecov.
|
|
@arturdm Any direction you can provide for me here? Given that AGP 4.0 just reached beta this plugin will be holding people back or forcing abandonment on an ever shortening timeline. |
latest agp
build.gradle
Outdated
|
|
||
| compileOnly 'com.google.code.findbugs:jsr305:3.0.2' | ||
|
|
||
| testImplementation(group: 'org.spockframework', name: 'spock-core', version: '1.1-groovy-2.4') { | ||
| exclude group: 'org.codehaus.groovy', module: 'groovy-all' | ||
| } | ||
| testImplementation 'com.android.tools.build:gradle:3.3.1' | ||
| testImplementation 'org.jetbrains.kotlin:kotlin-gradle-plugin:1.3.21' | ||
| testImplementation 'org.jetbrains.kotlin:kotlin-gradle-plugin:1.3.61' |
There was a problem hiding this comment.
Just a few callouts since this PR is aging just a bit (thanks for your awesome efforts!). Unless you want to target 1.3.61 specifically we're already to 1.3.72 stable version. Same with Gradle on line 25, we're at 3.6.3.
There was a problem hiding this comment.
Shouldn't affect if it gets merged as-is IMO, just if there's time/reason before @arturdm gets their eyes on it.
There was a problem hiding this comment.
yeah moving targets are hard. I'll go through and refresh this PR one more time. Personally I finally gave up waiting and did a custom internal plugin to handle the job this repo was serving.
There was a problem hiding this comment.
How custom? I'd love to see only if you're able to share.
There was a problem hiding this comment.
it's just a derivative version of this repo. ~200 lines of kotlin to replace this whole project.
custom in the sense: not just a copy/paste from here.
| @@ -7,7 +7,8 @@ plugins { | |||
| id 'com.jfrog.bintray' version '1.8.4' | |||
| } | |||
|
|
|||
| sourceCompatibility = JavaVersion.VERSION_1_5 | |||
| sourceCompatibility = JavaVersion.VERSION_1_8 | |||
| targetCompatibility = JavaVersion.VERSION_1_8 | |||
|
|
|||
There was a problem hiding this comment.
Will migration to the new version of the Gradle happen or not?
Gradle 6.0 - closes #72
AGP 3.5.2 - jump to the latest as an API dependency so things are easier to maintain.
Gradle task config avoidance. closes #66 *breaking changes to config DSL
use a "reports/jacoco/unitTest/variant/flavor/type" convention similar to a vanilla java project so that the outputs do not overlap with variants or other coverage reports external to this plugin.
makes plugin apply order not matter
adds support for com.android.dynamic-feature plugin
change to the output convention to ensure output overlap is not an issue and the dsl breaking changes related to the use of the gradle provider api's are probably the roughest parts here.
Let me know what you think and i'll update asap.