Skip to content
This repository has been archived by the owner on Aug 25, 2020. It is now read-only.

Updated code to keep up with the latest version of extension (3.0.3). #1

Open
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

kzvdar42
Copy link

Updated the code & wallpapers IDs file to keep up with the changes in the API.

Also upped the python to 3.4, cause the python 2 is deprecated.

@kzvdar42
Copy link
Author

@cgiAlexis, I've seen you've been trying to update the code, so I hope this helps)

@cgiAlexis
Copy link

This is amazing just to read and see how you've implemented it, thank you!

@4llan
Copy link

4llan commented Feb 20, 2020

Thanks, @kzvdar42. Very nice PR.

I was comparing the (1) https://earthview.withgoogle.com/download/{}.jpg vs (2) https://www.gstatic.com/prettyearth/assets/full/{}.jpg and noticed this:

  • All images are visually the same, except for copyright at the bottom
  • Same resolution: 1800x1200
  • the filesize of (1) is sometimes higher than (2) because they're not optmized. Found this comment in some (2) files: Optimized by JPEGmini 3.11.4.3 0x37a6e51a
  • About 5477 and 5478: (1) returns 404, (2) returns a valid wallpaper

@4llan
Copy link

4llan commented Feb 20, 2020

Missing ids

from https://earthview.withgoogle.com/_api/photos.json

from my old links:

@kzvdar42
Copy link
Author

Where did you get these new ids?

Because I just pulled all ids from their official chrome extension code.

@4llan
Copy link

4llan commented Feb 20, 2020

I've fetched https://earthview.withgoogle.com/_api/photos.json and sorted ids. I've updated my comment above. 5477 and 7014 are ids from my old notes.

@kzvdar42
Copy link
Author

Thanks, @4llan!
Your interest gave me the motivation to improve the code)
I added the missing ids, removed all dependencies, added handling of the 404 pages and updated the README with yours observations.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants