fix build #36
fix build #36
Conversation
|
|
| @@ -4,7 +4,7 @@ on: | |||
| push: | |||
| branches: [main] | |||
| workflow_run: | |||
| workflows: ["Notion and commit changes"] | |||
| workflows: ['Notion and commit changes'] | |||
There was a problem hiding this comment.
I think these changes are done by the github actions extension formatter
| name: string; | ||
| demoLink: string; | ||
| tags?: string[]; | ||
| description?: string; | ||
| postLink?: string; | ||
| demoLinkRel?: string; | ||
| [key: string]: any; |
There was a problem hiding this comment.
whole project needs to be prettier'd
There was a problem hiding this comment.
Seeing an issue with local dev since including @fastly/js-compute. Do you see the same issue, @sharunkumar, with yarn possibly?
| @@ -18,6 +18,7 @@ | |||
| "@astrojs/rss": "^4.0.7", | |||
| "@astrojs/sitemap": "^3.1.6", | |||
| "@astrojs/tailwind": "^5.1.0", | |||
| "@fastly/js-compute": "0.5.8", | |||
There was a problem hiding this comment.
I think this is problematic in my local dev environment:
yarn && yarn run dev
yarn install v1.22.22
warning package.json: No license field
warning [email protected]: No license field
[1/4] 🔍 Resolving packages...
[2/4] 🚚 Fetching packages...
error @fastly/[email protected]: The engine "node" is incompatible with this module. Expected version "^16 || ^18". Got "20.10.0"
error Found incompatible module.
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.There was a problem hiding this comment.
I looked at one of my prior setups from 7 months ago, and this dependency wasn't part of it back then but Fastly's Compute processes were part of the Github workflows.
There was a problem hiding this comment.
I think this is problematic in my local dev environment:
yarn && yarn run dev yarn install v1.22.22 warning package.json: No license field warning [email protected]: No license field [1/4] 🔍 Resolving packages... [2/4] 🚚 Fetching packages... error @fastly/[email protected]: The engine "node" is incompatible with this module. Expected version "^16 || ^18". Got "20.10.0" error Found incompatible module. info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.
your local node version is incompatible. use something like https://github.com/Schniz/fnm to manage node versions
There was a problem hiding this comment.
after installing and setting up fnm, run fnm use 18
No description provided.