bugfix: tests renaming and refactoring

arup-group · Nov 28, 2024 · 5d2f714 · 5d2f714
1 parent ef44d1a
commit 5d2f714
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 7 deletions.
diff --git a/...ts/Helpers/Assemble/AssembleModelLists.cs → ...lpers/Assemble/AssembleModelListsTests.cs b/...ts/Helpers/Assemble/AssembleModelLists.cs → ...lpers/Assemble/AssembleModelListsTests.cs
@@ -5,7 +5,7 @@
 
 namespace GsaGHTests.Helpers.Assemble {
   [Collection("GrasshopperFixture collection")]
-  public class AssembleModelLists {
+  public class AssembleModelListsTests {
     private const int DefaultId = 1;
     private const string ExpectedName = "create list test";
     private const string ExpectedDefinition = "1 2 3";
@@ -22,7 +22,7 @@ public void ListShouldReturnDefinitionWhenIdIsSet() {
 
     [Fact]
     public void ListShouldReturnDefinitionWhenIdIsNotSet() {
-      GsaList gsaList = GsaList(DefaultId);
+      GsaList gsaList = GsaList(null);
 
       Assert.Equal(DefaultId, gsaList.Id);
       Assert.Equal(ExpectedName, gsaList.Name);
@@ -39,10 +39,7 @@ private static GsaListGoo CreateListComponent(int? id) {
       var createListComponent = new CreateList();
       createListComponent.CreateAttributes();
 
-      if (id != DefaultId) {
-        ComponentTestHelper.SetInput(createListComponent, id, 0);
-      }
-
+      ComponentTestHelper.SetInput(createListComponent, id, 0);
       ComponentTestHelper.SetInput(createListComponent, ExpectedName, 1);
       ComponentTestHelper.SetInput(createListComponent, ExpectedDefinition, 2);
 

diff --git a/GsaGHTests/TestHelpers/ComponentTestHelper.cs b/GsaGHTests/TestHelpers/ComponentTestHelper.cs
@@ -151,7 +151,7 @@ public static void SetInput(GH_Component component, object obj, string name) {
     private static Param_GenericObject GetGenericParameterFor(object obj) {
       var input = new Param_GenericObject();
       input.CreateAttributes();
-      if (typeof(IQuantity).IsAssignableFrom(obj.GetType())) {
+      if (typeof(IQuantity).IsAssignableFrom(obj?.GetType())) {
         input.PersistentData.Append(new GH_UnitNumber((IQuantity)obj));
       } else {
         input.PersistentData.Append(new GH_ObjectWrapper(obj));