GSAGH-544: The 1D steel utilization contour range in Rhino is incorre…

…ct (#735)
arup-group · Dec 18, 2024 · d1820c0 · d1820c0
1 parent 313d612
commit d1820c0
Show file tree

Hide file tree

Showing 2 changed files with 39 additions and 3 deletions.
diff --git a/GsaGH/Parameters/5_Results/5_Extrema/SteelUtilisationExtremaKeyUtility.cs b/GsaGH/Parameters/5_Results/5_Extrema/SteelUtilisationExtremaKeyUtility.cs
@@ -5,9 +5,8 @@ namespace GsaGH.Parameters.Results {
   public static partial class ExtremaKeyUtility {
     public static (SteelUtilisationExtremaKeys Max, SteelUtilisationExtremaKeys Min) GetSteelUtilisationExtremaKeys<T>(
       this IDictionary<int, IList<T>> subset) {
-
-      var maxValue = new SteelUtilisation(double.MaxValue);
-      var minValue = new SteelUtilisation(0.0);
+      var maxValue = new SteelUtilisation(double.MinValue);
+      var minValue = new SteelUtilisation(double.MaxValue);
 
       var maxKeys = new SteelUtilisationExtremaKeys();
       var minKeys = new SteelUtilisationExtremaKeys();

diff --git a/GsaGHTests/1_BaseParameters/5_Results/Collections/SteelUtilisationTests.cs b/GsaGHTests/1_BaseParameters/5_Results/Collections/SteelUtilisationTests.cs
@@ -291,5 +291,42 @@ public void UpdateExtremaTest() {
       Assert.Equal(2, minKeys.Overall.Id);
       Assert.Equal(0, minKeys.Overall.Permutation);
     }
+
+    [Fact]
+    public void ShouldFindTheLargestAndSmallest() {
+      var dictionary = new Dictionary<int, IList<SteelUtilisation>>() {
+        {
+          3, new List<SteelUtilisation>() {
+            new SteelUtilisation(0),
+          }
+        }, {
+          2, new List<SteelUtilisation>() {
+            new SteelUtilisation(1),
+          }
+        },
+      };
+      (SteelUtilisationExtremaKeys max, SteelUtilisationExtremaKeys min) = dictionary.GetSteelUtilisationExtremaKeys();
+      Assert.Equal(2, max.Overall.Id);
+      Assert.Equal(3, min.Overall.Id);
+    }
+
+    [Fact]
+    public void ShouldLookAtAllItemsOnTheList() {
+      var dictionary = new Dictionary<int, IList<SteelUtilisation>>() {
+        {
+          3, new List<SteelUtilisation>() {
+            new SteelUtilisation(1),
+          }
+        }, {
+          2, new List<SteelUtilisation>() {
+            new SteelUtilisation(0),
+            new SteelUtilisation(2),
+          }
+        },
+      };
+      (SteelUtilisationExtremaKeys max, SteelUtilisationExtremaKeys min) = dictionary.GetSteelUtilisationExtremaKeys();
+      Assert.Equal(2, max.Overall.Id);
+      Assert.Equal(2, min.Overall.Id);
+    }
   }
 }