gsagh-366 #536
Closed
gsagh-366 #536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kpne
reviewed
Oct 5, 2023
Co-authored-by: Kristjan Nielsen <[email protected]>
kpne
reviewed
Oct 5, 2023
| internal Dictionary<string, GsaResultsValues> ACaseResultValues { get; private set; } | ||
| = new Dictionary<string, GsaResultsValues>(); | ||
|
|
||
| internal void AddACaseValue(string nodelist, GsaResultsValues values) { |
There was a problem hiding this comment.
Suggested change
| internal void AddACaseValue(string nodelist, GsaResultsValues values) { | |
| internal void AddAnalysisCaseValues(string nodelist, GsaResultsValues values) { |
kpne
reviewed
Oct 5, 2023
| @@ -7,6 +7,7 @@ | |||
| using GsaAPI; | |||
| using GsaGH.Helpers; | |||
| using GsaGH.Helpers.GsaApi; | |||
| using GsaGH.Parameters._5_Results; | |||
kpne
reviewed
Oct 5, 2023
| @@ -139,8 +140,8 @@ public class GsaResult { | |||
| /// Append to this dictionary to chache results | |||
| /// key = elementList | |||
| /// </summary> | |||
| internal Dictionary<string, GsaResultsValues> ACaseNodeDisplacementValues { get; set; } | |||
| = new Dictionary<string, GsaResultsValues>(); | |||
| internal GsaNodeDisplacement ACaseNodeDisplacementValues { get; set; } | |||
There was a problem hiding this comment.
Suggested change
| internal GsaNodeDisplacement ACaseNodeDisplacementValues { get; set; } | |
| internal GsaNodeDisplacement AnalysisCaseNodeDisplacements { get; set; } |
kpne
reviewed
Oct 5, 2023
| using System.Threading.Tasks; | ||
|
|
||
| namespace GsaGH.Parameters._5_Results { | ||
| public class GsaNodeDisplacement { |
There was a problem hiding this comment.
Suggested change
| public class GsaNodeDisplacement { | |
| public class GsaNodeDisplacements { |
File name should be changed as well
kpne
reviewed
Oct 5, 2023
Comment on lines
934
to
947
| if (Type == CaseType.AnalysisCase) { | ||
| if (!ACaseNodeDisplacementValues.ContainsKey(nodelist)) { | ||
| if (!ACaseNodeDisplacementValues.ACaseResultValues.ContainsKey(nodelist)) { | ||
| if (!ACaseNodeResults.ContainsKey(nodelist)) { | ||
| ACaseNodeResults.Add(nodelist, AnalysisCaseResult.NodeResults(nodelist)); | ||
| } | ||
|
|
||
| ACaseNodeDisplacementValues.Add(nodelist, | ||
| ACaseNodeDisplacementValues.AddACaseValue(nodelist, | ||
| ResultHelper.GetNodeResultValues(ACaseNodeResults[nodelist], lengthUnit)); | ||
| } | ||
|
|
||
| return new Tuple<List<GsaResultsValues>, List<int>>(new List<GsaResultsValues> { | ||
| ACaseNodeDisplacementValues[nodelist], | ||
| ACaseNodeDisplacementValues.ACaseResultValues[nodelist], | ||
| }, Model.Model.Nodes(nodelist).Keys.ToList()); | ||
| } |
There was a problem hiding this comment.
Should we move this to a method in the new class?
There was a problem hiding this comment.
not a 1 step I suppose
kpne
reviewed
Oct 5, 2023
| internal Dictionary<string, GsaResultsValues> ACaseResultValues { get; private set; } | ||
| = new Dictionary<string, GsaResultsValues>(); | ||
|
|
||
| internal void AddAnalysisCaseValue(string nodelist, GsaResultsValues values) { |
There was a problem hiding this comment.
Suggested change
| internal void AddAnalysisCaseValue(string nodelist, GsaResultsValues values) { | |
| internal void AddAnalysisCaseValues(string nodelist, GsaResultsValues values) { |
Codecov Report
@@ Coverage Diff @@
## main #536 +/- ##
=====================================
Coverage 89.9% 89.9%
=====================================
Files 296 297 +1
Lines 28277 28281 +4
=====================================
+ Hits 25430 25434 +4
Misses 2847 2847
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.