Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GsaGH-391 refactor quantities kn #555

Closed
wants to merge 27 commits into from

Conversation

kpne
Copy link
Contributor

@kpne kpne commented Oct 20, 2023

No description provided.

@kpne kpne requested a review from DominikaLos October 20, 2023 17:00
@kpne kpne requested a review from tlmnrnhrdt as a code owner October 20, 2023 17:00
@codecov
Copy link

codecov bot commented Oct 22, 2023

Codecov Report

Merging #555 (41f04c2) into epic/GsaGH-366 (78a3282) will decrease coverage by 3.8%.
The diff coverage is 90.2%.

Impacted file tree graph

@@               Coverage Diff                @@
##           epic/GsaGH-366    #555     +/-   ##
================================================
- Coverage            91.1%   87.3%   -3.8%     
================================================
  Files                 298     306      +8     
  Lines               28898   29066    +168     
  Branches                0    3823   +3823     
================================================
- Hits                26351   25400    -951     
+ Misses               2547    2543      -4     
- Partials                0    1123   +1123     
Files Coverage Δ
GsaGH/Components/5_Results/BeamDisplacements.cs 88.6% <100.0%> (-5.7%) ⬇️
GsaGH/Components/5_Results/BeamForcesAndMoments.cs 92.3% <100.0%> (-2.8%) ⬇️
...GH/Components/5_Results/BeamStrainEnergyDensity.cs 86.4% <100.0%> (-3.8%) ⬇️
...aGH/Components/5_Results/Element2dDisplacements.cs 89.3% <100.0%> (-4.7%) ⬇️
.../Components/5_Results/Element2dForcesAndMoments.cs 85.8% <100.0%> (-2.7%) ⬇️
GsaGH/Components/5_Results/Element2dStresses.cs 90.7% <100.0%> (-3.3%) ⬇️
...aGH/Components/5_Results/Element3dDisplacements.cs 86.7% <100.0%> (-4.1%) ⬇️
GsaGH/Components/5_Results/Element3dStresses.cs 90.1% <100.0%> (-3.6%) ⬇️
GsaGH/Components/5_Results/NodeDisplacements.cs 91.6% <100.0%> (-4.2%) ⬇️
GsaGH/Components/5_Results/ReactionForces.cs 93.7% <100.0%> (-2.5%) ⬇️
... and 26 more

... and 171 files with indirect coverage changes

@kpne kpne closed this Oct 25, 2023
@kpne kpne deleted the task/Gsagh-391_Refactor_Quantities-kn branch November 2, 2023 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants