Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GsaGH-366 Results Refactor Epic #562

Merged
merged 80 commits into from
Nov 13, 2023
Merged

GsaGH-366 Results Refactor Epic #562

merged 80 commits into from
Nov 13, 2023

Conversation

kpne
Copy link
Contributor

@kpne kpne commented Oct 27, 2023

No description provided.

DominikaLos and others added 30 commits October 10, 2023 12:23
@DominikaLos
gsagh-391 new class for gsa displacements quantities
e132b25
@DominikaLos
gsagh-391 first step
6cfab49
@DominikaLos
391 - rework + renaming
d7455c8
WIP
2cac8f5
revert to main
f0c15ea
fix type bug
3a50700
Updated new results
bb438e0
IGsaResult
d6c5896
@DominikaLos
fixed errors
70cbf63
merge main
e689031
Merge branch 'main' into task/Gsagh-391_Refactor_Quantities-kn
ecb6ef1
rename folder
b03d42b
fix pythagorean helper for baseunits not in API unit (angle unit)
734872d
DisplacementQuantity tests
058b0e1
NodeDisplacementTests
5571b15
@DominikaLos
added regression test for Xx values
9ae9a54
Max and Min test
19ffc1a
Merge branch 'task/Gsagh-391_Refactor_Quantities-kn' of https://githu…
87e1adf 
…b.com/arup-group/GSA-Grasshopper into task/Gsagh-391_Refactor_Quantities-kn
regression tests
9aa3e44
Use new results method
ea5f635
fix test after updating sample file
20837c4
update max/min method
16e5226
Extract INodeResultCache and IApiResult
6a35dc2
downgrade sample file
7e53a0c
remove usings
a525bf5
revert to main version
f5e2bd5
make constructors with API variables internal
41f04c2
cache
b80c07c
cleanup
380678a
remove unused usings
ef2c372
Kristjan Nielsen and others added 18 commits November 2, 2023 11:02
merge epic branch
e2caabc
@DominikaLos
Task/gsagh 406 node reaction forces (#558)
c298284 
* added regression tests

* rename

* added nodeReactionForce class + cache

* update null => 0

* fixed tests

* just don't look at this commit

---------

Co-authored-by: Kristjan Nielsen <[email protected]>
@DominikaLos
added node spring force cache class + tests, little refactoring to ma…
8b05f23 
…ke code more DRY
@kpne
task/gsagh-409 node spring forces (#563)
7e85b4b
Beam displacements
eddcb59
Element1d displacement and extrema
a533927
merge epic branch
8fb7587
fix merge
f2e942b
elem1d displacement tests
00b50ba
fix test
8a756a6
fix test
3012ad7
Envelope instead of Type
1eda6a3
find missing positions
855b458
update tests
1a977f8
Element1d Internal Forces
aff16d8
@kpne
Element1d Internal Forces (#565)
a92264a
@kpne
GsaGH-408 1d displacement results (#564)
fae61a5
@DominikaLos @kpne
gsagh-411 update node force components (#566)
0fd21e4 
* updated node components to use gsaResult2

* fix

* updated tests

* Update GsaGH/Components/5_Results/ReactionForces.cs

Co-authored-by: Kristjan Nielsen <[email protected]>

* Update GsaGH/Components/5_Results/SpringReactionForces.cs

Co-authored-by: Kristjan Nielsen <[email protected]>

* deserialisation

* fix

* GsaGH-411 kn (#567)

* test for values

* loop over ordered list of node ids

* fix reaction force restuls for special cases

---------

Co-authored-by: Kristjan Nielsen <[email protected]>
@codecov Codecov
Copy link

codecov bot commented Nov 9, 2023

Codecov Report

Merging #562 (0fd21e4) into main (78a3282) will decrease coverage by 4.5%.
The diff coverage is 79.0%.

Impacted file tree graph

@@           Coverage Diff           @@
##            main    #562     +/-   ##
=======================================
- Coverage   91.1%   86.7%   -4.5%     
=======================================
  Files        298     322     +24     
  Lines      28898   29596    +698     
  Branches       0    3884   +3884     
=======================================
- Hits       26351   25672    -679     
- Misses      2547    2810    +263     
- Partials       0    1114   +1114
Files Coverage Δ
GsaGH/Components/1_Properties/Create2dProperty.cs 90.3% <ø> (-3.8%) ⬇️
GsaGH/Components/3_Loads/LoadProperties.cs 91.6% <ø> (-5.8%) ⬇️
...GH/Components/5_Results/BeamStrainEnergyDensity.cs 86.4% <100.0%> (-3.8%) ⬇️
...aGH/Components/5_Results/Element2dDisplacements.cs 89.3% <100.0%> (-4.7%) ⬇️
.../Components/5_Results/Element2dForcesAndMoments.cs 85.8% <100.0%> (-2.7%) ⬇️
GsaGH/Components/5_Results/Element2dStresses.cs 90.7% <100.0%> (-3.3%) ⬇️
...aGH/Components/5_Results/Element3dDisplacements.cs 86.7% <100.0%> (-4.1%) ⬇️
GsaGH/Components/5_Results/Element3dStresses.cs 90.1% <100.0%> (-3.6%) ⬇️
GsaGH/Components/6_Display/Annotate.cs 97.0% <ø> (-2.0%) ⬇️
GsaGH/Components/6_Display/Contour1dResults.cs 90.1% <100.0%> (-2.8%) ⬇️
... and 48 more

... and 165 files with indirect coverage changes

@kpne kpne changed the base branch from main to release/GSA10.2.3 November 13, 2023 09:46
@kpne kpne marked this pull request as ready for review November 13, 2023 09:46
@kpne kpne merged commit 532c01a into release/GSA10.2.3 Nov 13, 2023
2 of 4 checks passed
@kpne kpne deleted the epic/GsaGH-366 branch November 13, 2023 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DominikaLos DominikaLos DominikaLos approved these changes

@tlmnrnhrdt tlmnrnhrdt Awaiting requested review from tlmnrnhrdt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kpne @DominikaLos