Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GSAGH-561 contour legend in rhino is cropped #732

Merged
merged 58 commits into from
Dec 19, 2024

Conversation

DominikaLos
Copy link
Collaborator

@DominikaLos DominikaLos commented Nov 28, 2024

Scale: 3
image

Scale: 1.5
image

Update: added extraOffset to make semicolon fit in first line

Copy link
Collaborator

@psarras psarras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried to do the changes on one of the files, but you can extend them on others.

GsaGH/Components/6_Display/AssemblyResults.cs Outdated Show resolved Hide resolved
GsaGH/Components/6_Display/AssemblyResults.cs Outdated Show resolved Hide resolved
GsaGH/Components/6_Display/AssemblyResults.cs Outdated Show resolved Hide resolved
GsaGH/Components/6_Display/Contour1dResults.cs Outdated Show resolved Hide resolved
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@arup-group arup-group deleted a comment from codecov bot Dec 4, 2024
@DominikaLos DominikaLos requested a review from psarras December 4, 2024 16:11
@DominikaLos DominikaLos marked this pull request as ready for review December 5, 2024 12:31
Copy link
Collaborator

@psarras psarras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be continued, but let me know if they make sense, especially the ones on the new classes.

GsaGH/Helpers/GH/Legend/ContourLegend.cs Outdated Show resolved Hide resolved
GsaGH/Helpers/GH/Legend/ContourLegendManager.cs Outdated Show resolved Hide resolved
GsaGH/Helpers/GH/Legend/ContourLegend.cs Show resolved Hide resolved
GsaGH/Helpers/GH/TextWrapper.cs Show resolved Hide resolved
GsaGH/Helpers/GH/Legend/ContourLegendConfiguration.cs Outdated Show resolved Hide resolved
GsaGHTests/Helpers/GH/Legend/LegendMenuBuilderTests.cs Outdated Show resolved Hide resolved
GsaGHTests/Helpers/GH/Legend/ContourLegendTests.cs Outdated Show resolved Hide resolved
GsaGHTests/Helpers/GH/Legend/ContourLegendTests.cs Outdated Show resolved Hide resolved
GsaGHTests/Helpers/GH/Legend/ContourLegendTests.cs Outdated Show resolved Hide resolved
@DominikaLos DominikaLos requested a review from psarras December 13, 2024 11:18
Copy link
Collaborator

@psarras psarras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

resolve the comments you caught up with already

GsaGH/Components/6_Display/AssemblyResults.cs Outdated Show resolved Hide resolved
GsaGH/Components/6_Display/AssemblyResults.cs Outdated Show resolved Hide resolved
GsaGH/Components/6_Display/AssemblyResults.cs Outdated Show resolved Hide resolved
GsaGH/Components/6_Display/Contour2dResults.cs Outdated Show resolved Hide resolved
GsaGH/Helpers/GH/Legend/ContourLegend.cs Outdated Show resolved Hide resolved
GsaGH/Components/6_Display/Contour2dResults.cs Outdated Show resolved Hide resolved
GsaGH/Components/6_Display/Contour3dResults.cs Outdated Show resolved Hide resolved
GsaGH/Components/6_Display/ContourNodeResults.cs Outdated Show resolved Hide resolved
GsaGH/Helpers/GH/Legend/ContourLegendConfiguration.cs Outdated Show resolved Hide resolved
GsaGH/Helpers/GH/Legend/LegendMenuBuilder.cs Outdated Show resolved Hide resolved
GsaGH/Helpers/GH/TextWrapper.cs Outdated Show resolved Hide resolved
GsaGH/Helpers/GH/TextWrapper.cs Outdated Show resolved Hide resolved
GsaGH/Helpers/GH/TextWrapper.cs Outdated Show resolved Hide resolved
@DominikaLos DominikaLos requested a review from psarras December 19, 2024 07:58
Copy link

sonarqubecloud bot commented Dec 19, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
16.5% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@psarras psarras enabled auto-merge (squash) December 19, 2024 14:19
@psarras psarras merged commit 9c386d9 into main Dec 19, 2024
7 of 8 checks passed
@psarras psarras deleted the bugfix/GSAGH-561-Contour-legend-in-Rhino-is-cropped branch December 19, 2024 14:21
Copy link

codecov bot commented Dec 19, 2024

Codecov Report

Attention: Patch coverage is 93.25843% with 42 lines in your changes missing coverage. Please review.

Project coverage is 90.4%. Comparing base (bbc49ea) to head (6ad1a92).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
GsaGH/Components/6_Display/Contour2dResults.cs 88.8% 16 Missing and 5 partials ⚠️
GsaGH/Helpers/GH/Legend/LegendMenuBuilder.cs 50.0% 13 Missing ⚠️
GsaGH/Components/6_Display/Contour3dResults.cs 90.9% 6 Missing ⚠️
GsaGH/Helpers/GH/Legend/ContourLegend.cs 96.6% 1 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff           @@
##            main    #732    +/-   ##
======================================
  Coverage   90.3%   90.4%            
======================================
  Files        526     531     +5     
  Lines      39419   39305   -114     
  Branches    4920    4919     -1     
======================================
- Hits       35615   35538    -77     
+ Misses      2534    2501    -33     
+ Partials    1270    1266     -4     
Files with missing lines Coverage Δ
GsaGH/Components/6_Display/AssemblyResults.cs 91.8% <100.0%> (+0.8%) ⬆️
GsaGH/Components/6_Display/Contour1dResults.cs 95.6% <100.0%> (+0.8%) ⬆️
GsaGH/Components/6_Display/ContourNodeResults.cs 93.9% <100.0%> (+1.0%) ⬆️
...GH/Helpers/GH/Legend/ContourLegendConfiguration.cs 100.0% <100.0%> (ø)
GsaGH/Helpers/GH/Legend/ContourLegendManager.cs 100.0% <100.0%> (ø)
GsaGH/Helpers/GH/TextWrapper.cs 100.0% <100.0%> (ø)
GsaGH/Helpers/GH/Legend/ContourLegend.cs 96.6% <96.6%> (ø)
GsaGH/Components/6_Display/Contour3dResults.cs 89.7% <90.9%> (+0.9%) ⬆️
GsaGH/Helpers/GH/Legend/LegendMenuBuilder.cs 50.0% <50.0%> (ø)
GsaGH/Components/6_Display/Contour2dResults.cs 93.4% <88.8%> (+0.8%) ⬆️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants