-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GSAGH-561 contour legend in rhino is cropped #732
GSAGH-561 contour legend in rhino is cropped #732
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried to do the changes on one of the files, but you can extend them on others.
…ttps://github.com/arup-group/GSA-Grasshopper into bugfix/GSAGH-561-Contour-legend-in-Rhino-is-cropped
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
…ttps://github.com/arup-group/GSA-Grasshopper into bugfix/GSAGH-561-Contour-legend-in-Rhino-is-cropped
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be continued, but let me know if they make sense, especially the ones on the new classes.
…ethods,. Legend: added bitmap, bitmapWidth, getFont, updated TextWrapper, removed interfaces, updated components
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
resolve the comments you caught up with already
Quality Gate failedFailed conditions |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #732 +/- ##
======================================
Coverage 90.3% 90.4%
======================================
Files 526 531 +5
Lines 39419 39305 -114
Branches 4920 4919 -1
======================================
- Hits 35615 35538 -77
+ Misses 2534 2501 -33
+ Partials 1270 1266 -4
|
Scale: 3
Scale: 1.5
Update: added extraOffset to make semicolon fit in first line