upstream changes until 2.16.0 #58

dtnaughton · 2024-01-22T14:34:36Z

Description & motivation

Changes:

This PR contains a lot of changes the branch is based on #57 which was not merged into main, but is the branch in which our production servers are based on.

To-do before merge:

Screenshots:

Validation of changes:

Checklist:

My pull request follows the guidelines in the Contributing guide?
My pull request does not duplicate any other open Pull Requests for the same update/change?
My commits are related to the pull request and do not amend unrelated code or documentation.
My code follows a similar style to existing code.
I have added appropriate tests.
I have updated or added relevant documentation.

References

…ot set (specklesystems#1687)

* feat(fe-2): improved logging * yarn lock update * attempted speckle/shared build fix * helm updates * Updates documentation for helm chart --------- Co-authored-by: Iain Sproat <[email protected]>

…echanism (specklesystems#1664)

…ct size (specklesystems#1685) * test(objects upload): adds a test for large object * print object too large messages in response * allows object maximum size to be configured

* WIP seq-logging * nuxt plugin + infra adjustments

…erns

…stems#1695) * fix(helm): only deploy frontend-2 if enabled in helm chart * Do not deploy frontend if frontend-2 is enabled

* Quote values

…leanup

…st duration metrics (specklesystems#1591) * replaces expressMonitoring.js

… to pass (specklesystems#1700)

… debug (specklesystems#1702) - log as info, not debug level

…isy logging (specklesystems#1703) * fix(fileimport): reduce noisiness of logging * fix(fileimport): return timeout error message to server

…systems#1704)

…server into dim/dui3

* feat(server): change default name of a server * Update 000-core.js

* fix: preparing automation backend for use in FE * minor migration adjustment * modelId only * more CR fixes * improved validation * WIP model automation status (specklesystems#1791) * additional run status insert validations * model card dialog * show view automation btn * story mock fixes * version card dialog --------- Co-authored-by: Gergő Jedlicska <[email protected]>

* fe subscriptions working * minor adjustment

* With Fabian's help we changed the way the default textures are loaded. They are now embeded using another rollup plugin as base64 directly into the js module * Embedded textures * Yarn lock stuff

…rrays as display values. It ignores them and logs a warning message (specklesystems#1795)

…s#1797)

…klesystems#1901) * test DX improvements + tests for token:write scope * protecting against scope elevation

dtnaughton · 2024-01-24T14:04:34Z

@Exilliar - this PR contains a lot of changes the branch is based on #57 which was not merged into main, but is the branch in which our production servers are based on.

This PR contains a lot of changes for DUI3/frontend-2 (neither of which we utilize currently) and we have not deviated from upstream, so generally there are no issues with receiving this code down.

A couple of key things to review and get a second set of eyes on to check if there are any concerns:

Server now allows guest mode (captured within this commit that contains most changes) 469e7b4. This will be toggled off by default on our servers (set in admin settings)
A server vulnerability was highlighted by Speckle Systems that:
Authorized apps with a token scope 'token write' were able to create a new token in excess of the privileges granted by the original token. Therefore a malicious actor could generated further tokens with other privileges the user held. This was due to the server not verifying that privileges granted to the new token were not in excess of those granted to the requesting token.
I've pulled down the relevant changes to patch this issue in ef57c69 and 51333df

dtnaughton · 2024-01-24T14:14:37Z

@Exilliar - I've also added a change to take our Americas server out of the github actions for our staging environment. Previously, this server would be deployed when the production or staging environment is deployed. At the request of Jeroen, this server is ready for production and therefore should be kept at par with prod code only, and not staging.

Exilliar

looks good!

Tested pushing up a test stream to staging from Rhion (haven't done Revit or Grasshopper, figured that would be overkill)

Also done the token creating test myself and it worked as expected

iainsproat and others added 30 commits July 12, 2023 00:40

ci(frontend-2): docker image should not be built if github token is n…

f0c7301

…ot set (specklesystems#1687)

feat(fe-2): improved logging (specklesystems#1684)

eaf925b

* feat(fe-2): improved logging * yarn lock update * attempted speckle/shared build fix * helm updates * Updates documentation for helm chart --------- Co-authored-by: Iain Sproat <[email protected]>

fix(fe2): apollo link logger missing

53c6871

fix: pino dep missing

3999372

fix(/objects): should return 400 error to invalid input data format/m…

9fe6ed3

…echanism (specklesystems#1664)

chore(objects upload): improves response when error due to large obje…

9f04188

…ct size (specklesystems#1685) * test(objects upload): adds a test for large object * print object too large messages in response * allows object maximum size to be configured

feat(fe2): client-side error logging to seq (specklesystems#1691)

93bd557

* WIP seq-logging * nuxt plugin + infra adjustments

fix(fe-2): adding server name to seq logging

0d6e971

experiments(dui3): WIP - needs minor readjustments with the .net patt…

eb0f440

…erns

fix(helm): only deploy frontend-2 if enabled in helm chart (specklesy…

05aa82b

…stems#1695) * fix(helm): only deploy frontend-2 if enabled in helm chart * Do not deploy frontend if frontend-2 is enabled

fix(helm test): works with frontend2 (specklesystems#1693)

54829ec

fix helm test frontend2 (specklesystems#1696)

c3dc3ac

* Quote values

experiments(dui3): introducing generic bridge (cef/webview2) + some c…

2467b47

…leanup

feat(prometheus): add status code and improved path grouping to reque…

ea6d2c9

…st duration metrics (specklesystems#1591) * replaces expressMonitoring.js

ci(codecov): base uploader is deprecated (specklesystems#1698)

89e7393

chore(fileimport): improve logging (specklesystems#1697)

87a7397

ci(publish): all publish steps should wait on all required test steps…

8d21a86

… to pass (specklesystems#1700)

fix(helm README): add missing description end tag (specklesystems#1701)

dc4c808

fix(fileimport): logging of child process should not be suppressed as…

9c3d595

… debug (specklesystems#1702) - log as info, not debug level

fix(fileimport): return timeout error message to server & suppress no…

b9b9f7d

…isy logging (specklesystems#1703) * fix(fileimport): reduce noisiness of logging * fix(fileimport): return timeout error message to server

fix(fileimport): destructuring for...of should use entries() (speckle…

fd04a1d

…systems#1704)

Implement sketchup bridge to tryHoistBindings

203ca50

experiments(dui3): cleanup

047a764

Merge branch 'dim/dui3' of https://github.com/specklesystems/speckle-…

09a0e91

…server into dim/dui3

Create SketchupBridge for tryHoistBinding

bf84060

experiments(dui3): cleanup

520a65c

experiments(dui3): added test bindings

77aad56

experiments(dui3): wip ITestBinding + page

fd46eae

Add testBindings functions -validated for sketchup

8597c32

experiments(dui3): cleanup

9d812e9

gjedlicska and others added 22 commits September 12, 2023 18:12

feat(server): change default name of a server (specklesystems#1786)

7b40f25

* feat(server): change default name of a server * Update 000-core.js

feat(fe2): automations status subscriptions (specklesystems#1793)

eb441d7

* fe subscriptions working * minor adjustment

fix(fe2): fixed nested anchor hydration mismatches (specklesystems#1794)

407646f

fix(fe2): automation status subscription not working for new status

894c869

fix(fe2): more automationStatus subscription improvements

9209ed6

Viewer Embedded Textures (specklesystems#1770)

edcd1b6

* With Fabian's help we changed the way the default textures are loaded. They are now embeded using another rollup plugin as base64 directly into the js module * Embedded textures * Yarn lock stuff

Merge branch 'main' of github.com:specklesystems/speckle-server

a5b2997

The converter no longer throws errors on null display values inside a…

842ff79

…rrays as display values. It ignores them and logs a warning message (specklesystems#1795)

fix(fe2): viewer resources fully unloading when adding/removing models

bec2ffd

fix(fe2): @apollo/client d edupe to resolve mismatched versions

9a0933d

fix(fe2): made onboarding bar load in SSR (specklesystems#1796)

1738c07

fix(server): automate FKs disallowing project deletion (specklesystem…

9423d2f

…s#1797)

fix(fe2): move versions not working

144819a

feat(ui-components): new CommonAlert features

696c09e

Merge branch 'tag-2.16.0' into dn/dev/2.16.0

469e7b4

fix: preview service build dependency version

732d860

update job number role validation

7bfa074

fix(server): protecting against scope elevation in PAT creation (spec…

ef57c69

…klesystems#1901) * test DX improvements + tests for token:write scope * protecting against scope elevation

fix: preventing PATs from creating PATs

51333df

fix(fe): remove duplicate code on settings

6b6a345

add job number input to stream repo

19203ff

dtnaughton self-assigned this Jan 22, 2024

dtnaughton requested a review from Exilliar January 24, 2024 13:50

dtnaughton marked this pull request as ready for review January 24, 2024 14:04

remove amr server from staging env ci/cd

2d28c3a

Exilliar approved these changes Feb 15, 2024

View reviewed changes

dtnaughton merged commit 57624fb into main Feb 26, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

upstream changes until 2.16.0 #58

upstream changes until 2.16.0 #58

dtnaughton commented Jan 22, 2024 •

edited

Loading

dtnaughton commented Jan 24, 2024

dtnaughton commented Jan 24, 2024

Exilliar left a comment

upstream changes until 2.16.0 #58

upstream changes until 2.16.0 #58

Conversation

dtnaughton commented Jan 22, 2024 • edited Loading

Description & motivation

Changes:

To-do before merge:

Screenshots:

Validation of changes:

Checklist:

References

dtnaughton commented Jan 24, 2024

dtnaughton commented Jan 24, 2024

Exilliar left a comment

Choose a reason for hiding this comment

dtnaughton commented Jan 22, 2024 •

edited

Loading