Update memberType conversion for element/member2d

arup-group · Feb 9, 2022 · 15e61f9 · 15e61f9
1 parent 3928b51
commit 15e61f9
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 5 deletions.
diff --git a/Objects/Converters/ConverterGSA/ConverterGSA/ConverterGSA.ToNative.cs b/Objects/Converters/ConverterGSA/ConverterGSA/ConverterGSA.ToNative.cs
@@ -598,12 +598,14 @@ private List<GsaRecord> GSAMember2dToNative(Base speckleObject)
       var speckleMember = (GSAMember2D)speckleObject;
       //Dynamic properties
       var dynamicMembers = speckleMember.GetMembers();
+      var memberType = Enum.Parse(typeof(Objects.Structural.Geometry.MemberType2D), speckleMember.memberType.ToString());
+
       var gsaMember = new GsaMemb()
       {
         ApplicationId = speckleMember.applicationId,
         Index = speckleMember.GetIndex<GsaMemb>(),
         Name = speckleMember.name,
-        Type = ToNative((MemberType2D)speckleMember.memberType),
+        Type = ToNative((MemberType2D)memberType),
         Colour = speckleMember.colour?.ColourToNative() ?? Colour.NotSet,
         Dummy = speckleMember.isDummy,
         IsIntersector = true,
@@ -2818,7 +2820,7 @@ public Speckle.GSA.API.GwaSchema.MemberType ToNative(Objects.Structural.Geometry
         case Objects.Structural.Geometry.MemberType2D.VoidCutter2D: return Speckle.GSA.API.GwaSchema.MemberType.Void2d;
         default:
           Report.ConversionErrors.Add(new Exception(speckleMemberType.ToString() + " is not currently a supported member type for a 2D element."));
-          return Speckle.GSA.API.GwaSchema.MemberType.NotSet;
+          return Speckle.GSA.API.GwaSchema.MemberType.Generic2d;
       }
     }
 

diff --git a/...onverters/ConverterRevit/ConverterRevitShared/Partial Classes/ConvertAnalyticalSurface.cs b/...onverters/ConverterRevit/ConverterRevitShared/Partial Classes/ConvertAnalyticalSurface.cs
@@ -144,6 +144,9 @@ private Element2D AnalyticalSurfaceToSpeckle(AnalyticalModelSurface revitSurface
       //(mesh.faces, mesh.vertices) = GetFaceVertexArrFromSolids(solidGeom);
       //speckleElement2D.baseMesh = mesh;	  
 
+      //speckleElement2D.displayMesh = GetElementDisplayMesh(Doc.GetElement(revitSurface.GetElementId()),
+      // new Options() { DetailLevel = ViewDetailLevel.Fine, ComputeReferences = false });
+
       var prop = new Property2D();
 
       // Material
@@ -258,9 +261,6 @@ private Element2D AnalyticalSurfaceToSpeckle(AnalyticalModelSurface revitSurface
 
       GetAllRevitParamsAndIds(speckleElement2D, revitSurface);
 
-      //speckleElement2D.displayMesh = GetElementDisplayMesh(Doc.GetElement(revitSurface.GetElementId()),
-      // new Options() { DetailLevel = ViewDetailLevel.Fine, ComputeReferences = false });
-
       return speckleElement2D;
     }
   }