Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix shouldShowDevMenuOrReload in RELEASE
Summary: In RELEASE mode, the `devSupportManager` received is ReleaseDevSupportManager for which `showDevOptionsDialog()` & `handleReloadJS()` is a no-op https://github.com/facebook/react-native/blob/main/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/devsupport/ReleaseDevSupportManager.java Which is expected since this is a capability only in Dev mode(useDeveloperSupport = true). However, ATM `shouldShowDevMenuOrReload()` returns true in RELEASE as well which is a bug. Since there is no need for `shouldShowDevMenuOrReload()` in RELEASE, changing it's logic to introduce that check, early exit and return false in case of RELEASE. Changelog: [Android][Fixed] shouldShowDevMenuOrReload() in RELEASE mode Reviewed By: RSNara Differential Revision: D56851473
- Loading branch information